New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794410 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Page Info Bubble: Use ContentSetting instead of the combobox index to determine currently checked item.

Project Member Reported by patricia...@chromium.org, Dec 13 2017

Issue description

With #secondary-ui-md turned on, or with MacViews, the Page Info bubble on desktop uses |Combobox|es instead of |MenuButton|s. There is currently a bug in the code used for |Combobox|es that causes any permission which has a different number to the default three options (Ask, Allow, and Block) to display the incorrect menu item string for the corresponding |ContentSetting| that is currently selected. For example, this previously caused the Ads content setting to show up as 'Allow' even though it was set to 'Block' (see  issue 789587  for more context).

Since there are currently no content settings which have a different number of menu items in their |Combobox| drop-down, this is OK because this bug will never get hit. Obviously if this ever changes, this should be fixed.

Probably the fix should involve relying on the |command_id|s (which would be the ContentSetting enum values) given to the Combobox instead of the currently selected index. ComboboxModelAdapter::GetCheckedIndex() would probably be a good place to do this since it checks |IsCommandIdChecked()| (but assumes that |command_id| is the same as the combobox checked index).
 
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment