"PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl" is flaky |
|||||
Issue description"PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 36 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYWdlTG9hZE1ldHJpY3NCcm93c2VyVGVzdC5Ob25IdHRwT3JIdHRwc1VybAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 14 2017
,
Dec 14 2017
,
Dec 14 2017
,
Dec 14 2017
I reprod this on Win 10. The problem is with the PageLoad.Experimental.Renderer* metrics which don't have the same filtering rules. I see two approaches: 1. Rename them to be prefixed with PageLoad.Internal 2. Filter them out in the browsertest Bryan, WDYT?
,
Dec 14 2017
Detected 53 new flakes for test/step "PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYWdlTG9hZE1ldHJpY3NCcm93c2VyVGVzdC5Ob25IdHRwT3JIdHRwc1VybAw. This message was posted automatically by the chromium-try-flakes app.
,
Dec 14 2017
Thanks Charles for digging in! This really helps, since I don't have a Windows machine. I put together a patch to address this here: https://chromium-review.googlesource.com/c/chromium/src/+/826386
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7221ce9c43366b8ea5fe64a6cd7418875c30c272 commit 7221ce9c43366b8ea5fe64a6cd7418875c30c272 Author: Bryan McQuade <bmcquade@chromium.org> Date: Fri Dec 15 05:34:58 2017 Fix page load metrics flake, and re-enable test. Page load metrics browser tests sometimes want to assert that no page load metrics are logged for a given page load. They do this by checking to see that no PageLoad.* histograms were logged, but excluding PageLoad.Internal.* histograms, which are considered internal and thus allowed to be logged during non tracked page loads. Recently, the PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl test started flaking on Windows, due to PageLoad.Experimental.Renderer.* metrics being logged during this page load. These are really internal metrics, so should use the PageLoad.Internal.* naming convention, which also allows them to be ignored by this test. Bug: 794408 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I593adf3b8c995e50b74431cc89e782cf4456abff Reviewed-on: https://chromium-review.googlesource.com/826386 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#524335} [modify] https://crrev.com/7221ce9c43366b8ea5fe64a6cd7418875c30c272/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/7221ce9c43366b8ea5fe64a6cd7418875c30c272/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp [modify] https://crrev.com/7221ce9c43366b8ea5fe64a6cd7418875c30c272/tools/metrics/histograms/histograms.xml
,
Dec 15 2017
Detected 4 new flakes for test/step "PageLoadMetricsBrowserTest.NonHttpOrHttpsUrl". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYWdlTG9hZE1ldHJpY3NCcm93c2VyVGVzdC5Ob25IdHRwT3JIdHRwc1VybAw. This message was posted automatically by the chromium-try-flakes app.
,
Dec 22 2017
Was this fixed or not? The bug is still marked as untriaged, but apparently some work seems to have taken place... At least removing from sheriff queue on the assumption that the last detected flakes actually predated the CL above it...
,
Dec 22 2017
,
Dec 22 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by noel@chromium.org
, Dec 13 2017Owner: bmcquade@chromium.org