Cherry-pick an upstream fix for UTF-8 to UTF-8 converter |
||||||||||||
Issue descriptionICU 60.1 introduced a bug in UTF-8 to UTF-8 converter (discovered by asan but reproducible in a non-ASAN build). Chrome does not use the API in question as far as I know. Nonetheless, it'd be better to cherry-pick an upstream fix. Upstream bug: https://ssl.icu-project.org/trac/ticket/13510
,
Dec 13 2017
,
Dec 13 2017
,
Dec 13 2017
,
Dec 13 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/icu.git/+/438929b62fd5dfd8e6b6daff150490d7ac14312f commit 438929b62fd5dfd8e6b6daff150490d7ac14312f Author: Jungshik Shin <jshin@chromium.org> Date: Wed Dec 13 21:08:33 2017 Cherry-pick an upstream fix for UTF8 to UTF8 conversion Bug: 794390 Change-Id: I31a1e622b38060c322be8086cc8aefdafb431a1b Reviewed-on: https://chromium-review.googlesource.com/822188 Reviewed-by: Mark Mentovai <mark@chromium.org> [modify] https://crrev.com/438929b62fd5dfd8e6b6daff150490d7ac14312f/README.chromium [add] https://crrev.com/438929b62fd5dfd8e6b6daff150490d7ac14312f/patches/u8tou8.patch [modify] https://crrev.com/438929b62fd5dfd8e6b6daff150490d7ac14312f/source/common/ucnv_u8.cpp
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27be5b2f24250e2b35d2c0746a685c2ff4ab784f commit 27be5b2f24250e2b35d2c0746a685c2ff4ab784f Author: Jungshik Shin <jshin@chromium.org> Date: Thu Dec 14 21:38:31 2017 Roll ICU to 94d819f Add a test for German time format (12hr with AM/PM marker). It has 3 changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/e3b480d..94d819f 2017-12-13 jshin@chromium.org Update German AM/PM marker to the previous value 2017-12-13 jshin@chromium.org Cherry-pick an upstream fix for UTF8 to UTF8 conversion 2017-12-12 jshin@chromium.org Cherry-pick an upstream fix for Calendar class Bug: 794737 , 794390 , 792537 Test: base_unittests --gtest_filter=TimeFormat*.*TimeOfDayDE Test: crbug.com/794737#c2 Change-Id: Ifa6d31624cbd9d4edc1b776e34527d8e842f7290 Reviewed-on: https://chromium-review.googlesource.com/826363 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#524189} [modify] https://crrev.com/27be5b2f24250e2b35d2c0746a685c2ff4ab784f/DEPS [modify] https://crrev.com/27be5b2f24250e2b35d2c0746a685c2ff4ab784f/base/i18n/time_formatting_unittest.cc
,
Dec 15 2017
Fixed. I'll wait for canary to go live with this change and ask for merge to 64.
,
Dec 16 2017
,
Dec 19 2017
related bug: bug 790944 . It turned out that we do use the api in question for XML parsing.
,
Dec 19 2017
,
Jan 2 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/e3f547afefe52835be482b32421c016dc90ddc4f commit e3f547afefe52835be482b32421c016dc90ddc4f Author: Jungshik Shin <jungshik@google.com> Date: Tue Jan 02 18:38:21 2018
,
Jan 2 2018
In bug 794737 , I got a merge approval and ICU was rolled for M60 branch to include a change recorded in comment 6.
,
Jan 2 2018
,
Mar 24 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by js...@chromium.org
, Dec 13 2017