GTK native nav buttons clipped and fuzzy with KDE's Breeze theme
Reported by
peter.es...@gmail.com,
Dec 12 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. login to a KDE Plasma session with the default Breeze theme 2. start chrome 3. maximize chrome window What is the expected behavior? properly renders nav buttons What went wrong? nav buttons are clipped and fuzzy Did this work before? N/A Chrome version: 63.0.3239.84 Channel: stable OS Version: Kubuntu 17.10 Flash Version:
,
Dec 13 2017
,
Dec 13 2017
"@Inhouse: As the issue needs to be checked by logging in to KDE Plasma with OS Kubuntu 17.10, requesting some one from in house team to have a look into it and help in further investigation. Hence adding label : TE-NeedsTriageFromHYD Thanks!"
,
Dec 13 2017
,
Dec 13 2017
Unable to reproduce on Chrome 63.0.3239.84 using the Breeze GTK theme. +thestig are you seeing this issue?
,
Dec 13 2017
re: comment 5 - but are you using the same version of KDE as the one shipped with Kubuntu 17.10?
,
Dec 14 2017
I gave it a try with Kubuntu live and I'm still unable to repro. OP, are you using any special DPI or scaling settings?
,
Dec 14 2017
> OP, are you using any special DPI or scaling settings? I tested different scaling settings on my UHD screen and tested it in a VM with FHD & without scaling. I noticed that chrome is NOT maximized on your screenshot, did you test that? This bug occurs only when chrome is miximized.
,
Dec 14 2017
c#8: Thanks, able to reproduce when the window is maximized
,
Dec 21 2017
Also notice, that the button in the middle should change when the window is maximized.
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19eee98dfd576b4c9fc5b4e59ab2ec41c381cbe4 commit 19eee98dfd576b4c9fc5b4e59ab2ec41c381cbe4 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Jan 02 22:11:55 2018 Gtk3: Fix Breeze theme unmaximize button GTK windows have the .maximized class applied when they are maximized. Child widgets may be styled differently depending on this state, as the Breeze theme does with the unmaximize button. Unlike other themes, the Breeze theme uses a bitmap to render the titlebuttons, so it was the only theme so far affected by this issue. With this fix, the unmaximize button looks like a diamond instead of an up arrow. BUG= 794358 R=thestig@chromium.org Change-Id: I462d78665e3d1e30d05535af632415c981f3f432 Reviewed-on: https://chromium-review.googlesource.com/842857 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526541} [modify] https://crrev.com/19eee98dfd576b4c9fc5b4e59ab2ec41c381cbe4/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc
,
Jan 2 2018
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7df10e3bf7ecd845801f06b4b06b5f7bc39cf79b commit 7df10e3bf7ecd845801f06b4b06b5f7bc39cf79b Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Jan 03 05:46:47 2018 Gtk3: Fix Breeze theme frame buttons clipping BUG= 794358 Change-Id: I48f8e5a6f129734a76fad5622bd1680c4946dffe Reviewed-on: https://chromium-review.googlesource.com/847680 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526631} [modify] https://crrev.com/7df10e3bf7ecd845801f06b4b06b5f7bc39cf79b/chrome/browser/ui/libgtkui/nav_button_provider_gtk3.cc
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89ec1819efbb2cbec603db94a07229a098f2bb0 commit b89ec1819efbb2cbec603db94a07229a098f2bb0 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Jan 03 06:38:30 2018 Gtk3: Fix fuzzy breeze frame buttons when using scale factors > 1 When using scale factors > 1, it is necessary to set the scale factor on all GtkStyleContext's so that GTK will fetch higher resolution assets. This was only seen on the Breeze theme, because it's the only one that uses bitmap backgrounds. BUG= 794358 R=erg@chromium.org Change-Id: Ib2c42e4869156caba94f377b583cbac96f44ad98 Reviewed-on: https://chromium-review.googlesource.com/847683 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526638} [modify] https://crrev.com/b89ec1819efbb2cbec603db94a07229a098f2bb0/chrome/browser/ui/libgtkui/gtk_util.cc
,
Jan 3 2018
KDE plasma set up is unavailable with HYD chrome-TE team. Requesting someone from MTV team to verify this issue. Thanks!
,
Jan 3 2018
Should be fixed in Chromium 65 or later. Note that in maximized mode, the icons will appear slightly smaller because the Breeze theme reports the button size to be taller than it actually is, so it gets downsized for the smaller tabstrip. I've created a patch here https://github.com/KDE/breeze-gtk/pull/3#issuecomment-355097411 But I'm having trouble creating a KDE identity account, so it has not landed yet.
,
Jan 3 2018
Thanks! Now if there were canary builds for Linux, I could enjoy the fix right now :) *wink* https://bugs.chromium.org/p/chromium/issues/detail?id=622061
,
Feb 22 2018
Issue 814622 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gov...@chromium.org
, Dec 13 2017Labels: Needs-Triage-M63