Add metrics for usage of --site-per-process |
||||||||
Issue descriptionSimilarly to issue 793471 , it'd be good to have some metrics in place to be able to tell how often users turn on --site-per-process in practice, either via a command-line flag, via about:flags, or via enterprise policy. Opening this bug to track adding/merging these metrics.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207b7651d583795cb62f2bfe9ae6866632d75337 commit 207b7651d583795cb62f2bfe9ae6866632d75337 Author: Alex Moshchuk <alexmos@chromium.org> Date: Wed Dec 13 00:48:27 2017 Add metrics to count how often site isolation flags get turned on. Bug: 794336 , 793471 Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523628} [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/browser/browser_main_loop.cc [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/common/site_isolation_policy.cc [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/common/site_isolation_policy.h [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The histogram is verified on Mac 65.0.3293.0 (Official Build) canary (64-bit). Requesting merge to M63 and M64.
,
Dec 13 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
Approving merge to M63 branch 3239 based on comment #3. Please also apply applicable OSs. I believer it is Desktop & Chrome OS. Thank you.
,
Dec 13 2017
Also pls continue to monitor canary data and let us know if you see anything unusal due to this change. Thanks again.
,
Dec 13 2017
Approving merge to M64 branch 3282 based on comment #3.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6fbb056aee60f54c887662d45733d3a5e1d7841 commit c6fbb056aee60f54c887662d45733d3a5e1d7841 Author: Nasko Oskov <nasko@chromium.org> Date: Wed Dec 13 17:32:00 2017 Add metrics to count how often site isolation flags get turned on. (Merge in M63) Bug: 794336 , 793471 TBR=nasko@chormium.org Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523628} Reviewed-on: https://chromium-review.googlesource.com/824905 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#675} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/browser/browser_main_loop.cc [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/common/site_isolation_policy.cc [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/common/site_isolation_policy.h [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1130f3449d61fec70168d65b11c93762e6db427 commit e1130f3449d61fec70168d65b11c93762e6db427 Author: Nasko Oskov <nasko@chromium.org> Date: Wed Dec 13 17:35:43 2017 Add metrics to count how often site isolation flags get turned on. (Merge in M64) Bug: 794336 , 793471 Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523628} Reviewed-on: https://chromium-review.googlesource.com/824906 Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#204} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/browser/browser_main_loop.cc [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/common/site_isolation_policy.cc [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/common/site_isolation_policy.h [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The fix and all merges have landed, so marking as fixed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gov...@chromium.org
, Dec 13 2017