Figure out how to handle STYLE_EMPHASIZED in Harmony |
|||
Issue descriptionA couple of dialogs are using STYLE_EMPHASIZED to get bold text for URLs that should not be links as well as user email addresses that should not prompt mailto: actions. Before Harmony these were handled by bolding the text, but as there's no bold font usage in Harmony this is unemphasized for now, which looks wonky. Attaching how the styled label for restoring the default search engine looks under Harmony without STYLE_EMPHASIZED styling. We need to figure out what to do with it. Related mocks with bold present are in issue 698785 , but they are not updated for Harmony, so they just look like mocks for the old implementation.
,
Dec 20 2017
Yeah, let's include Bold as an optional font weight in Harmony if possible. Can we only bold the URLs if it's present in the body copy? Using a bold weight AND a title font (15pt) is a bit overkill visually and will create more text wrapping with the extended character width.
,
Dec 21 2017
,
Dec 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497efd752862c762cccfe472e8e47f35c7d47933 commit 497efd752862c762cccfe472e8e47f35c7d47933 Author: Peter Boström <pbos@chromium.org> Date: Sat Dec 23 00:56:22 2017 Use bold for STYLE_EMPHASIZED in body contexts. Bug: chromium:698785 , chromium:794325 Change-Id: Idc35cd777c5d9c5232cd728cc57df9c21101f611 Reviewed-on: https://chromium-review.googlesource.com/843017 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#526115} [modify] https://crrev.com/497efd752862c762cccfe472e8e47f35c7d47933/chrome/browser/ui/views/harmony/harmony_typography_provider.cc
,
Dec 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pbos@chromium.org
, Dec 13 2017