milo: Fix "Patch" link under "Trigger Info" on tryjob builds to point to the correct patchset |
||
Issue descriptionThe "Gerrit CL" link on a tryjob page takes you to the latest patchset of the source CL. It should take you to the specific patchset that triggered the job. For example, see: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/607270 The link at the top takes you to: https://chromium-review.googlesource.com/c/822293 It *should* take you to: https://chromium-review.googlesource.com/c/822293/1 To see why the distinction is important, notice the tryjob results. If I click the CL link on a failing tryjob, I'd expect to be taken to the patchset that triggered it so I can view other tryjob results (ie: if it was a flake or not).
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/226ac77c86bbff8f1528537f838b10b8b11b2f6d commit 226ac77c86bbff8f1528537f838b10b8b11b2f6d Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Dec 15 04:33:17 2017 milo: link to the right Gerrit patch in tryjobs. Also reduce copy-pasta. R=jchinlee@chromium.org Bug: 794318 Change-Id: I27b5abdd833fa4cfd9adf3c006f3131c198a141c Reviewed-on: https://chromium-review.googlesource.com/825522 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/226ac77c86bbff8f1528537f838b10b8b11b2f6d/milo/buildsource/buildbot/build.go [modify] https://crrev.com/226ac77c86bbff8f1528537f838b10b8b11b2f6d/milo/buildsource/buildbot/build_test.go [modify] https://crrev.com/226ac77c86bbff8f1528537f838b10b8b11b2f6d/milo/buildsource/buildbot/expectations/gerritCL.1234.build.json [modify] https://crrev.com/226ac77c86bbff8f1528537f838b10b8b11b2f6d/milo/buildsource/buildbot/testdata/gerritCL.1234.json [modify] https://crrev.com/226ac77c86bbff8f1528537f838b10b8b11b2f6d/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
,
Dec 15 2017
,
Dec 16 2017
,
Dec 19 2017
Dope! thnx Andrii, I'm already using it a bunch
,
Dec 19 2017
Me too :) Also, it's was fun to write some code after 1 week of only doc+config editing :P |
||
►
Sign in to add a comment |
||
Comment 1 by tandrii@chromium.org
, Dec 13 2017