New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794317 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Gate in-browser mDNS discovery on firewall check / user gesture on Windows

Project Member Reported by imch...@chromium.org, Dec 12 2017

Issue description

See related  issue 593167 . I suspect there needs to be logic to gate mDNS discovery in CastMediaSinkService similar to the extension side. Otherwise we might run into the same issue as before. (dbbrooks to confirm)
 

Comment 1 by mfo...@chromium.org, Dec 12 2017

We can probably re-use the same logic, but instead of calling through to the Cast MRP we can start the in-browser discovery service.

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7818c96d72777c7d68f750a4ffa80cd611e306e4

commit 7818c96d72777c7d68f750a4ffa80cd611e306e4
Author: Derek Cheng <imcheng@chromium.org>
Date: Thu Dec 14 00:01:03 2017

[Media Router] Gate mDNS discovery on Windows.

mDNS discovery can trigger a firewall prompt on a fresh user-level
Chrome install on Windows or if there are no existing firewall rules
for mDNS traffic(?). This patch applies the same gating logic to
the mdns logic in in-browser cast discovery.

TODO: merge this patch back to M64.

Bug:  794317 
Change-Id: I5df1a2f60eb3a8411b642fc8996f2e0279912401
Reviewed-on: https://chromium-review.googlesource.com/823244
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523942}
[modify] https://crrev.com/7818c96d72777c7d68f750a4ffa80cd611e306e4/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
[modify] https://crrev.com/7818c96d72777c7d68f750a4ffa80cd611e306e4/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h
[modify] https://crrev.com/7818c96d72777c7d68f750a4ffa80cd611e306e4/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/7818c96d72777c7d68f750a4ffa80cd611e306e4/chrome/browser/media/router/mojo/media_router_desktop.h
[modify] https://crrev.com/7818c96d72777c7d68f750a4ffa80cd611e306e4/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc

Labels: Merge-Request-64
Owner: imch...@chromium.org
Status: Fixed (was: Unconfirmed)
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 15 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Fixed)
verified this on canary 65.0.3295.0
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f4d6d47ee2eccd523c244d837b1762e80e672d9

commit 2f4d6d47ee2eccd523c244d837b1762e80e672d9
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Dec 15 20:36:08 2017

[Media Router] Gate mDNS discovery on Windows.

mDNS discovery can trigger a firewall prompt on a fresh user-level
Chrome install on Windows or if there are no existing firewall rules
for mDNS traffic(?). This patch applies the same gating logic to
the mdns logic in in-browser cast discovery.

TODO: merge this patch back to M64.

TBR=imcheng@chromium.org

(cherry picked from commit 7818c96d72777c7d68f750a4ffa80cd611e306e4)

Bug:  794317 
Change-Id: I5df1a2f60eb3a8411b642fc8996f2e0279912401
Reviewed-on: https://chromium-review.googlesource.com/823244
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523942}
Reviewed-on: https://chromium-review.googlesource.com/830666
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#243}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/2f4d6d47ee2eccd523c244d837b1762e80e672d9/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
[modify] https://crrev.com/2f4d6d47ee2eccd523c244d837b1762e80e672d9/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h
[modify] https://crrev.com/2f4d6d47ee2eccd523c244d837b1762e80e672d9/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/2f4d6d47ee2eccd523c244d837b1762e80e672d9/chrome/browser/media/router/mojo/media_router_desktop.h
[modify] https://crrev.com/2f4d6d47ee2eccd523c244d837b1762e80e672d9/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc

Sign in to add a comment