New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794312 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2%-4.5% regression in rasterize_and_record_micro.top_25 at 522757:522789

Project Member Reported by fmea...@chromium.org, Dec 12 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 12 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=794312

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cbdaf1f44feec100244b6ee0c3e5cf6efd16e015a96d3d1423c1c4380a6b636a


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Dec 12 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14944eca040000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 13 2017

๐Ÿ˜ฟ Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14944eca040000

Comment 4 by dtu@chromium.org, Dec 13 2017

Cc: csmartdalton@google.com
Owner: bsalo...@google.com
Looks like https://github.com/catapult-project/catapult/issues/3921 , a failure to resolve the skia DEPS roll.

Luckily, the roll only has one commit.

Remove instanced rendering
By bsalomon@google.com ยท Fri Dec 08 13:41:10 2017 +0000
skia @ f06c3582677270c741a5e4fb366ec8b5d4ec4c21

Comment 5 by bsalo...@google.com, Dec 13 2017

Status: WontFix (was: Untriaged)
This change delete code that was never called from Chrome. If it really is due to this change then it'd have to be something like code or class layout, vtable size, or something along those lines.
Status: Assigned (was: WontFix)
Who would be the right person to track down any of your hypotheses?

Comment 7 by bsalo...@google.com, Dec 14 2017

Cc: bsalo...@google.com
Owner: benhenry@chromium.org
I suppose one could use profiling tools to look at cache behavior, etc on this or similarly configured machine any possibly identify what changed. But whether any one of those conjectures is true or not, this doesn't seem actionable as whatever the cause, we aren't likely to restore >4K lines of dead code to get this performance back. AFAICT a small number of tests on one Mac are affected. If this was more widespread or a larger performance change I'd think it'd be worth more investigation as maybe we could get this performance back shy of reverting this change. However, given the size of the potential win and the nebulousness of figuring out the root cause I'm inclined to think it isn't worth the opportunity cost. I did look into Skia's standalone performance metrics for this change and found a mix of negligible performance increases and decreases (https://perf.skia.org/e/?begin=1512682143&end=1512753192&keys=5662757143707648&xbaroffset=31590 and https://perf.skia.org/e/?begin=1512682143&end=1512753192&keys=5745745709760512&xbaroffset=31590).

Comment 8 by benhenry@google.com, Dec 15 2017

Status: WontFix (was: Assigned)
Fair enough.

Sign in to add a comment