New issue
Advanced search Search tips

Issue 794298 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

can we use codecs on iOS build?

Project Member Reported by reed@google.com, Dec 12 2017

Issue description

The current skia BUILD.gn skips our codec code on iOS. This means I have to disable a unittest, but it also means the skia apis will always fail in this environment. Do we need to keep them disabled on iOS?
 

Comment 2 by reed@google.com, Dec 12 2017

Perhaps skia could use its wrappers for iOS here, rather than linking in png/jpg/etc. This would allow our api to still function, but use apple's code.

Comment 3 by cblume@chromium.org, Dec 12 2017

I suspect this can be fixed as part of the larger project to consolidate image decoders.

Prior to using SkCodec, Blink uses a specific library for decoding jpegs. However, Chomium uses a different library for decoding its assets (outside of Blink).

(Some details are fuzzy here but the concept holds. Maybe it is pngs? Maybe it is Blink and PDFium not Blink and Chromium.)

I don't recall exactly why libjpeg_turbo isn't being included in the iOS builds. But I think it is because what I described above. I believe Blink uses libjpeg_turbo and Chromium uses libjpeg. Since iOS should never include Blink, it consequently never includes libjpeg_turbo.

Anyway, if we consolidate all of the various image decoders to just rely on Skia, I believe we can stop excluding SkCodec from iOS builds.

Comment 4 by reed@google.com, Dec 13 2017

yea, I'll work with scroggo to do that.
Components: Internals>Skia

Sign in to add a comment