New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794295 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

[SPv175+] Supoort border radius without overflow clip

Project Member Reported by wangxianzhu@chromium.org, Dec 12 2017

Issue description

In the following case:
  <div style="border-radius: 50%; width: 100px; height: 100px; background: green">
    <div style="width: 80px; height: 80px; background: blue"></div>
  </div>
we should create a paint property node for border radius clip which will apply to the background of the outer div only.

 
Actually we are already correct for the above case because the background are painted by FillRoundedRect without clipping. There are other cases that we use RoundedInnerRectClipper to clip background painting for SPv1. We need to issue real clip drawing operation for SPv175+ in the cases.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b8d15c0b235802cd8b57b776c8c096a5e3c384

commit 59b8d15c0b235802cd8b57b776c8c096a5e3c384
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Dec 13 23:59:56 2017

[SPv175+] Output InnerBorderRadiusClip for replaced elements if needed

Replaced elements (except SVGRoot which uses the normal overflow clip/
border-radius clip rule) with border-radius will apply border radius clip
on their foreground, so we need to output InnerBorderRadiusClip for them,
and set proper chunk properties when painting their foregrounds.

Bug:  794295 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I206db7fcf55a99187cf1f8961f5f286d482f1bf2
Reviewed-on: https://chromium-review.googlesource.com/823177
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523940}
[modify] https://crrev.com/59b8d15c0b235802cd8b57b776c8c096a5e3c384/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/59b8d15c0b235802cd8b57b776c8c096a5e3c384/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/59b8d15c0b235802cd8b57b776c8c096a5e3c384/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/59b8d15c0b235802cd8b57b776c8c096a5e3c384/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment