New issue
Advanced search Search tips

Issue 794289 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[MD Extensions] Extra whitespace can cause empty search results.

Project Member Reported by dpa...@chromium.org, Dec 12 2017

Issue description

Repro steps:

Assuming you have an extension installed with title "Google calendar"

1) Search for "google c". It finds it.
2) Search for "google  c". It does not find it.

We should probably collapse consecutive whitespace to a single character.


 

Comment 1 by aee@chromium.org, May 23 2018

Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a98202469c13e82bc107d8bbade2e76740d70f7

commit 9a98202469c13e82bc107d8bbade2e76740d70f7
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri May 25 21:56:37 2018

WebUI: for search in toolbar, replace multiple whitespace with single space

Bug:  794289 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1ed00732e07bd0f9b3bdf2cf97cd257d8054f8e
Reviewed-on: https://chromium-review.googlesource.com/1069793
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562027}
[modify] https://crrev.com/9a98202469c13e82bc107d8bbade2e76740d70f7/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/9a98202469c13e82bc107d8bbade2e76740d70f7/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Comment 3 by aee@chromium.org, May 25 2018

Status: Fixed (was: Started)

Sign in to add a comment