[MD Extensions] No link to open CWS page of an extension |
||||||||||||||
Issue description
,
Dec 12 2017
Also note that the "Size" is not displayed anywhere in the new UI (even with Dev mode on).
,
Dec 12 2017
Agreed both of these would be useful. Alan, thoughts? Note: the old dialog UI is actually only available on platforms that support Views UI (i.e., not mac).
,
Dec 12 2017
Re #1: Placing the link under "Source" makes sense since that's where we also show the link to where the extension lies on disk (when loaded from source) Re #2: Do our non-Developer users care about the size of an extension? With the link to the web store we can already see the size of the extension there. dpapad@ mentioned Dev Mode, maybe it should be only shown in dev mode to avoid cluttering UX for most users (if my assumption that most users don't care is true)
,
Dec 12 2017
#4(#2): I suspect that non-dev users will care if something takes 'a lot of space' or 'not very much'. For the moment that's probably best handled by showing the size. Maybe someday it could be done as the accurate size in dev-mode and in non-dev mode it could give a suggestion on whether the extension is hogging a lot of space. I.e. I think they'd mostly want to know if this is something they should remove to free up space or whether the space is negligible. So, yeah, I think that some (a small percentage I'd guess) non-dev users do care about the size.
,
Dec 13 2017
,
Dec 13 2017
+1 to dschuyler's comment about size considerations in #5. I think it is worth including. And +1 to also including the store entry point.
,
Dec 13 2017
Re: icon We just need the standard iron-icon outlink vertically centered in the row as you see in the (outdated) attachment. Re: size I think I'm going to air on the side of not showing the size of the extension. As someone who's a casual consumer of extensions, I wouldn't know the difference between a 10KB extension and a 10MB extension. I can be convinced to include it in the developer mode, but I don't think it's necessary for v1 launch.
,
Dec 13 2017
,
Dec 13 2017
#8 Re: size What if non-dev mode showed a choice of just a few strings (maybe two or three max). - Size: Small (less than 10MB) - Size: Large (more than 10MB) - Size: Huge (more than 100MB) In dev-mode we'd straight up show the size, without commentary. On my phone (where I am more of a user rather than a developer) I generally want to know what is eating up space (so I can remove it if it's not that important to me). I don't really care in that environment whether something is 1MB or 5MB. I just care whether something is being a hog or not. I think there'd be a parallel here for non-dev desktop users.
,
Dec 13 2017
#11: to be clear, that was a suggestion/nice-to-have. I'm not arguing for including it in the initial release; especially if it is available in dev-mode.
,
Dec 13 2017
,
Dec 13 2017
,
Dec 13 2017
@bettes: > Re: size I think I'm going to air on the side of not showing the size of the extension. As someone who's a casual consumer of extensions, I wouldn't know the difference between a 10KB extension and a 10MB extension. I can be convinced to include it in the developer mode, but I don't think it's necessary for v1 launch. I think this *is* important to show. I (mostly) agree that 10k and 10m are pretty similar and a user might not care, but Chrome Apps can have arbitrary amounts of storage, and I think users *do* care about 10MB vs 10GB. We also don't surface this information anywhere else I know of, which is particularly bad for CrOS. I think we do need to surface this information (even outside of dev mode).
,
Dec 13 2017
The Web Store does display the size of extensions/apps on the details page, so if we are able to include the web store link in MD extensions v1, perhaps this becomes a *slightly* lower priority - but I still think it is an important feature to include in MD extensions and we should do our best to get it in to v1.
,
Dec 13 2017
#16 Tip: Devlin had mentioned that some extensions are small in the store, but can expand quite a bit in use. So the store might say 200KB, and locally it may be using many GBs. So the store size isn't a good read on the local size.
,
Dec 13 2017
,
Dec 13 2017
FYI, I don't see 'size' currently being communicated back to JS. For the CWS link, there is a 'homepage' field, including a boolean and a URL. It is not clear to me what the boolean indicates though, see [1] as well as the screenshot, where the boolean is false, but the URL is valid. [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/developer_private/extension_info_generator.cc?l=411,412
,
Dec 13 2017
#19 I think the bool is saying whether the extension specified a (custom) home page or whether they are using the default store page. I'm basing hat on: https://developer.chrome.com/extensions/manifest/homepage_url
,
Dec 13 2017
Any thoughts on where in the details list the URL and/or Size should show on the details page (at the top? the bottom? between section A and B)?
,
Dec 13 2017
#21: For the size, maybe a new section after "Version" dedicated to size? For the URL, Alan posted thoughts at #9. Having said that, I think that the "source" section would also be a good candidate. It already includes a link that opens the default file explorer for unpacked extensions. Also, FYI tracing backwards from the UI, looking for where the "size" calculation occurs, I ended up at [1]. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc?&l=291
,
Dec 14 2017
Some new findings about the homepage URL. There is a leftover (dead code) shouldShowHomepageButton_() method at [1]. Doing some code archaeology, found that it was added at CL [2] and removed in the immediatly next CL [3], when new mocks became available. It still unclear to me whether we want to display both the homepage URL (which could be a non-CWS URL) and the CWS URL. My proposal at #23 is solely for the CWS URL. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/detail_view.js?l=120 [2] https://codereview.chromium.org/2522303002 [3] https://codereview.chromium.org/2723613004
,
Dec 14 2017
FYI, I created a new bug to track the missing "Size" info, since the URL and the size are independent issues, and require different fixes in the code.
,
Dec 14 2017
Forgot to link to the other bug. Here, https://bugs.chromium.org/p/chromium/issues/detail?id=794794
,
Dec 14 2017
@24, according to the documentation in #20, it seems like the homepage URL is really only relevant to extensions that are hosted outside of CWS, which is no longer possible on Windows, Mac & Chrome OS. For extensions hosted in the CWS (e.g. all publicly distributed extensions on Windows/Mac/CrOS) the homepage URL defaults to the CWS URL. So I think we should only display the CWS URL.
,
Dec 14 2017
#27 > it seems like the homepage URL is really only relevant to extensions that are hosted outside of CWS The homepage URL specified in manifest.json changes the link of the first menu item (the extension name) in the extension's toolbar icon context menu, which is a handy method of quickly opening the extension's homepage/support/website/etc. Just because the URL *defaults* to CWS doesn't mean it cannot be different.
,
Dec 14 2017
@27 - Echoing woxxom@'s sentiment. Extensions, both in and out of the webstore, can (and do) set their own home page url to whatever they want; they don't have to use the default. The documentation is simply saying that if you were to host outside the webstore, it's particularly useful (because there's no default fallback) - it's not saying that the webstore url is a replacement. I think it's important to have both URLs, and the old page did this (at least on views-supporting platforms with the app info dialog).
,
Dec 15 2017
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11a86d5232447ed53128491dc3c3fcd66424d351 commit 11a86d5232447ed53128491dc3c3fcd66424d351 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Dec 15 04:38:08 2017 [MD extensions] View-in-store feature for Details page This CL adds a View in store link row that links to the extension home page as well as a link row for the Chrome Web Store page for the extension. Bug: 794286 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06a8c078f0659adc3c69e6139133ec9cf6a81d9a Reviewed-on: https://chromium-review.googlesource.com/826473 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524325} [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/extensions/api/developer_private/extension_info_generator.cc [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/resources/md_extensions/service.js [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/common/extensions/api/developer_private.idl [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/extensions/common/manifest_url_handlers.cc [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/extensions/common/manifest_url_handlers.h [modify] https://crrev.com/11a86d5232447ed53128491dc3c3fcd66424d351/third_party/closure_compiler/externs/developer_private.js
,
Dec 15 2017
The CL description would have been clearer written as "This CL adds a Developer website link row that takes the user to the (developer's) extension home page. This is only shown if a "homepage_url" is present in the extension's manifest file. This also adds as a link row for the Chrome Web Store page for the extension. This row is not shown if the extension was not downloaded from the chrome web store, such as when loading an unpacked extension. Both of these feature (going to these URLs) were present in the pre-MD extensions UI. "
,
Dec 15 2017
Just closing the loop on my comment in #27. Thanks woxxom@ and rdevlin@ for the clarifications. Displaying both links (as pictured in dschuyler's screenshots) SGTM.
,
Dec 15 2017
,
Dec 16 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18 2017
As discussed in meeting, Extensions MD launch is behind a flag. Change has been tested and verified in Canary. Approving merge to M64 branch:3282
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27e00a22a7118167b0029fa314376e4781cd5bc4 commit 27e00a22a7118167b0029fa314376e4781cd5bc4 Author: Dave Schuyler <dschuyler@chromium.org> Date: Mon Dec 18 23:42:13 2017 [MD extensions] View-in-store feature for Details page This CL adds a View in store link row that links to the extension home page as well as a link row for the Chrome Web Store page for the extension. TBR=dschuyler@chromium.org (cherry picked from commit 11a86d5232447ed53128491dc3c3fcd66424d351) Bug: 794286 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I06a8c078f0659adc3c69e6139133ec9cf6a81d9a Reviewed-on: https://chromium-review.googlesource.com/826473 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#524325} Reviewed-on: https://chromium-review.googlesource.com/833334 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#280} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/extensions/api/developer_private/extension_info_generator.cc [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/resources/md_extensions/service.js [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/common/extensions/api/developer_private.idl [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/chrome/test/data/webui/extensions/extension_detail_view_test.js [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/extensions/common/manifest_url_handlers.cc [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/extensions/common/manifest_url_handlers.h [modify] https://crrev.com/27e00a22a7118167b0029fa314376e4781cd5bc4/third_party/closure_compiler/externs/developer_private.js
,
Dec 19 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dpa...@chromium.org
, Dec 12 2017