New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794275 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Keyboard shortcuts page icons too small

Project Member Reported by dpa...@chromium.org, Dec 12 2017

Issue description

The icon of each extension is currently 16x16. I think 20x20 is more aligned with other places in the UI, and looks a bit better.
 
icon_16px.png
11.6 KB View Download
icon_20px.png
9.7 KB View Download

Comment 1 by dpa...@chromium.org, Dec 12 2017

Note that the icon_20px screenshot is not 100% correct. The text on the 2nd line needs more left margin to still align with the top row's text.

Comment 2 by bettes@chromium.org, Dec 12 2017

20x20 LGTM. And yes, alignment of the text as suggest in c1 is preferred 

Comment 3 by dpa...@chromium.org, Feb 26 2018

Cc: aee@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 4 by aee@chromium.org, Feb 26 2018

Status: Assigned (was: Available)

Comment 5 by dpa...@chromium.org, Feb 26 2018

Owner: aee@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0329d2ee7386116319558fa7d0de9d163ac35b0f

commit 0329d2ee7386116319558fa7d0de9d163ac35b0f
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Feb 27 04:13:50 2018

MD Extensions: in keboard shortcuts extensions settings, set extension
    icon size to 20x20, align text

Bug:  794275 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7bdaf43dce5074c4b758d27ae47afb54b1d2750
Reviewed-on: https://chromium-review.googlesource.com/937961
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539399}
[modify] https://crrev.com/0329d2ee7386116319558fa7d0de9d163ac35b0f/chrome/browser/resources/md_extensions/keyboard_shortcuts.html

Comment 7 by aee@chromium.org, Feb 27 2018

Status: Fixed (was: Started)
Labels: TE-Verified-M66 TE-Verified-66.0.3357.0
Able to reproduce this issue on build without fix(observed small icon for extension), hence verifying the fix on latest canary 66.0.3357.0 using Mac 10.13.3, Windows 10 and Ubuntu 14.04.

Observing bigger icon when compared to build without fix. Attaching screenshots for reference.

Hence adding Verified labels.
Build with fix.png
12.1 KB View Download
Build without fix.png
12.1 KB View Download

Sign in to add a comment