New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794256 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Manifest install fails if the user has a policy-installed certificate

Project Member Reported by elawrence@chromium.org, Dec 12 2017

Issue description

InstallableManager::IsContentSecure returns false if the security_level is security_state::SECURE_WITH_POLICY_INSTALLED_CERTIFICATE.

Instead of groveling security states directly, this function should call the security_state::IsSslCertificateValid method instead.
 
Components: -Blink>AppManifest UI>Browser>WebAppInstalls
Labels: OS-Android OS-Linux OS-Mac OS-Windows
Thanks for catching this! Switching to the right component.
Labels: -OS-Linux -OS-Android -OS-Windows -OS-Mac
Technically, this is only Chrome because the policy-installed certificate state only exists on that platform.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/863211316ea87a733176192bb72c773aae0d4158

commit 863211316ea87a733176192bb72c773aae0d4158
Author: Eric Lawrence <elawrence@chromium.org>
Date: Tue Dec 12 23:08:11 2017

Allow Installation with a policy-installed cert

Installation requires that the security level of the page be SECURE or
EV_SECURE, but this omitted the equivalent state on ChromeOS with a
policy-installed certificate. This CL ensures that all valid HTTPS
states permit installation.

Bug:  794256 
Change-Id: I8ac7f2e6a7ca215197a32ec5ee534410d20d82b0
Reviewed-on: https://chromium-review.googlesource.com/823152
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523592}
[modify] https://crrev.com/863211316ea87a733176192bb72c773aae0d4158/chrome/browser/installable/installable_manager.cc

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment