New issue
Advanced search Search tips

Issue 794237 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Make it possible to create DataElements from strings without copying data.

Project Member Reported by mmenke@chromium.org, Dec 12 2017

Issue description

Currently, creating a DataElement requires copying all data it will contain.  This seems like an unnecessary source of overhead, as we convert URLFetchers over to using DataElements for uploads.  We should update the class to avoid this extra copy.

URLFetchers also do an unnecessary copy here, so this overhead exists in the current world, too, but this seems like a good time to remove it, and we're adding another copy as we switch APIs, since we have to send the strings over Mojo now.

 

Comment 1 by mek@chromium.org, Dec 12 2017

Blink>Storage does not seem like the right component, as this is completely unrelated to the way storage uses DataElement? Storage code only uses DataElement to actually store data, so copying data is always the right thing to do there.

Anyway, I think we already decided that the correct thing to do was to fork DataElement in two separate classes for the storage and non-storage use-cases (and I think it might make sense to do that sooner rather than later, especially as you're making more and more changes like the one discussed in this bug).

Comment 2 by mmenke@chromium.org, Dec 12 2017

The code is in storage/common/, which has blink>storage listed as its component.

If we split it, I guess we'd need a conversion from blink types to services/network types?

Comment 3 by mmenke@chromium.org, Dec 12 2017

Components: Internals>Services>Network
Owner: ----
Status: Available (was: Assigned)
Actually, going to leave this unassigned - if we're going to gate this on splitting up the consumers of DataElements, this is several orders of magnitude more involved that I anticipated, and I won't have time for it in the foreseeable future.

Comment 4 by mmenke@chromium.org, Mar 15 2018

Components: -Blink>Storage
Removing storage label, as this is now part of services/network.

Comment 5 by dxie@chromium.org, May 17 2018

Owner: mmenke@chromium.org
Status: Assigned (was: Available)
hey matt, do we need this for the initial canary launch of network service? 

Comment 6 by mmenke@chromium.org, May 17 2018

Owner: ----
Status: Available (was: Assigned)
I don't think so - I don't think we'll even need it for full launch, since this affects both the legacy and the new codepaths, I believe (Well, the "new" legacy codepath).

Think this is reasonable to leave a a P3.

Comment 7 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue

Sign in to add a comment