New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794218 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Refactoring: Update OfflinePageModel::GetPagesByURL and OfflinePageUtils::SelectPagesForURL to minimize namespace and tab ID handling

Project Member Reported by fgor...@chromium.org, Dec 12 2017

Issue description

Update OfflinePageModel::GetPagesByURL and OfflinePageUtils::SelectPagesForURL to minimize namespace and tab ID handling

Because the former is used almost exclusively by the latter we can simply a lot.

This may require a bit work around duplicate handling, but overall the code could be much simplified.
 

Comment 1 by dim...@chromium.org, Jan 31 2018

Labels: -Type-Bug Type-Task
Owner: romax@chromium.org
Status: Assigned (was: Untriaged)
Yafei, could you please look and decide if we need Asana workitem for that

Comment 2 by romax@chromium.org, Feb 3 2018

there might not be a huge difference, I have a patch and will upload later.

Comment 3 by romax@chromium.org, Feb 3 2018

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/900445

Comment 4 by romax@chromium.org, Feb 8 2018

Status: WontFix (was: Started)
This doesn't seem like a simplification, so closing as won't fix.
This might be aligned with the exposing of tasks.

Sign in to add a comment