New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794210 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Not on Chrome anymore
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 787005
issue 807641



Sign in to add a comment

Improve the process to add java/android dependencies

Project Member Reported by dgn@chromium.org, Dec 12 2017

Issue description

We recently went through updating some libraries hosted on Maven repositories (Google Play Services and Support Library) and we plan to add Dagger soon, which is also hosted on a Maven repository. This is now the case for most libraries in the Android world, as Gradle and Android Studio makes fetching and using them trivial.
That ease of use is not something we get to experience with Chromium’s build system. There are many hurdles: downloading the libraries and their dependencies, writing the GN files, going through open source review, etc. As Dagger’s annotation processor has a lot of dependencies, it's a good opportunity to take time to improve the process, which would impact updating the dependency later, and adding other new dependencies to chrome.

Design doc: go/chromium-m2-repo

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1b678fa67398a5f77836cc9bf8dcfcb60e4420b

commit b1b678fa67398a5f77836cc9bf8dcfcb60e4420b
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Jan 31 14:38:05 2018

🔧 Allow providing README for license.py in 3p subdirectories

Additionally to scaning the first level of third_party for
README.chromium files, these directories can now contain an
additional_readme_paths.json file that lists subdirectories
that will contain the actual third_party dependencies to
take into account for credits generation.

Bug: 794210
Change-Id: If6eef9fcd615bd96b9a260f9ae4d0c0c4fd6405a
Reviewed-on: https://chromium-review.googlesource.com/822612
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533270}
[modify] https://crrev.com/b1b678fa67398a5f77836cc9bf8dcfcb60e4420b/tools/licenses.py

Comment 2 by dgn@chromium.org, Jan 31 2018

Blocking: 807641
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8736d858c675abc4dda8e698967b2a08a83a66b

commit b8736d858c675abc4dda8e698967b2a08a83a66b
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Apr 05 04:29:24 2018

🔧 Migrate the Android Support Lib to android_deps

Exercises and applies the new dependency download mechanism
from crrev.com/c/819771
Note: The CL enables the android_deps repo, but that can be
reverted by settings the gn variable enable_android_deps_repository
to false, the former binaries and targets are still all valid.

TBR=klobag@chromium.org

Bug: 794210
Change-Id: Ia29ee554a9bbb3c38bd8f88d16af484da2ee439b
Reviewed-on: https://chromium-review.googlesource.com/837189
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548323}
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/DEPS
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/build/config/android/config.gni
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/BUILD.gn
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/additional_readme_paths.json
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_core_common/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_core_common/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_core_common/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_common/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_common/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_common/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_runtime/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_runtime/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/android_arch_lifecycle_runtime/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_animated_vector_drawable/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_animated_vector_drawable/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_animated_vector_drawable/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_appcompat_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_appcompat_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_appcompat_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_cardview_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_cardview_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_cardview_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_design/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_design/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_design/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_gridlayout_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_gridlayout_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_gridlayout_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_leanback_v17/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_leanback_v17/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_leanback_v17/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_mediarouter_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_mediarouter_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_mediarouter_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_multidex/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_multidex/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_multidex/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_palette_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_palette_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_palette_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_leanback_v17/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_leanback_v17/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_leanback_v17/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v14/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v14/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v14/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_preference_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_recyclerview_v7/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_recyclerview_v7/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_recyclerview_v7/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_annotations/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_annotations/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_annotations/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_compat/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_compat/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_compat/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_ui/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_ui/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_ui/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_utils/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_utils/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_core_utils/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_fragment/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_fragment/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_fragment/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_media_compat/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_media_compat/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_media_compat/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v13/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v13/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v13/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v4/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v4/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_v4/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_vector_drawable/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_vector_drawable/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_support_vector_drawable/cipd.yaml
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_transition/LICENSE
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_transition/README.chromium
[add] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/third_party/android_deps/repository/com_android_support_transition/cipd.yaml
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/tools/android/roll/android_deps/build.gradle
[modify] https://crrev.com/b8736d858c675abc4dda8e698967b2a08a83a66b/tools/android/roll/android_deps/buildSrc/src/main/groovy/BuildConfigGenerator.groovy

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/72726061423e009ecd4bdbbccdc68053c12c1b89

commit 72726061423e009ecd4bdbbccdc68053c12c1b89
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Apr 05 13:40:53 2018

Opt out of "Migrate the Android Support Lib to android_deps".

(to unblock DEPS roll)

Bug: chromium:794210,  webrtc:9118 
TBR: phoglund@webrtc.org
Change-Id: I7a97f1493b970f923f799a9e9e6fe9e924ad1dcf
Reviewed-on: https://webrtc-review.googlesource.com/67061
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22749}
[modify] https://crrev.com/72726061423e009ecd4bdbbccdc68053c12c1b89/.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4123a5e9892f0353f62fe5b80a00f634ca891839

commit 4123a5e9892f0353f62fe5b80a00f634ca891839
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 06 06:32:58 2018

Roll src/third_party/webrtc/ 4c9b3c840..19aab2ee7 (16 commits)

https://webrtc.googlesource.com/src.git/+log/4c9b3c840df3..19aab2ee7c6b

$ git log 4c9b3c840..19aab2ee7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:812974,chromium:827080,chromium:None,chromium:794210,chromium:825524


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If6b26fb8305b2e0d8c796358684d52a63d181a77
Reviewed-on: https://chromium-review.googlesource.com/999352
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548696}
[modify] https://crrev.com/4123a5e9892f0353f62fe5b80a00f634ca891839/DEPS

Sign in to add a comment