New issue
Advanced search Search tips

Issue 794208 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

WPT Import: Use Buildbucket directly to trigger and collect tryjob results

Project Member Reported by qyears...@chromium.org, Dec 12 2017 
This is an idea from discussion in https://crrev.com/c/819573. This may be something that we should or must do when running wpt-import via LUCI rather than BuildBot in the future.

Background:
git cl is intended for humans, not scripts. git cl try-results --json was added for use by WPT importer, but we could also directly use the Buildbucket API for triggering tryjobs and collecting details about the results. There is already a Python Buildbucket client that could be used.

Note from Andrii:
> If you migrate to calling buildbucket binary that we currently provide on swarming tasks (this is what I showed you yesterday as what is used by buildbucket recipe_module), then it'd just work in LUCI (post-Buildbot) world.
> I doubt git cl will work out of the box though, but that's something that has to be fixed anyway since WPT-importer isn't the only script relying on git cl try.

Resources:

https://chromium.googlesource.com/infra/infra/+/master/appengine/cr-buildbucket/doc/index.md
https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/buildbucket.py

Comment 1 by no...@chromium.org, Dec 12 2017 

since this is recipes, perhaps buildbucket recipe module should be used
https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/buildbucket/
it suypports more that depot_tools/buildbucket.py, including LUCI-provided auth tokens floating in the LUCI environment.

Comment 2 by robertma@chromium.org, Dec 12 2017 

I'm surprised to learn about the background. Yeah, given the context, I agree we should move away from hacking `git cl`, at least for managing the try jobs.

> since this is recipes, perhaps buildbucket recipe module should be used

Is there an easy way to import infra stuff in webkitpy? There is a recipe, but it simply calls the script in webkitpy. Besides, we'd also like to make the tool standalone (can be used on local workstations directly). If not, buildbucket.py seems better.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment