New issue
Advanced search Search tips

Issue 794207 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Random compilation failure in //third_party/WebKit/Source/platform/heap due to missing dep.

Project Member Reported by mharanc...@opera.com, Dec 12 2017 
Recently in Opera we often encounter random build failure in heap jumbo target:

$(PRJ_ROOT_DIR)chromium\src\out\release\gen\services\network\public\interfaces\cors.mojom-shared.h
../..\services/network/public/cpp/cors_error_status.h(10): fatal error C1083: Cannot open include file: 'services/network/public/interfaces/cors.mojom-shared.h': No such file or directory
../..\services/network/public/cpp/cors_error_status.h(10): fatal error C1083: Cannot open include file: 'services/network/public/interfaces/cors.mojom-shared.h': No such file or directory

Reproduced reliably on chromium master branch, just do clean build of heap target:

ninja -C out/Debug/ heap

and it ends up with:

[1445/1462] CXX obj/third_party/WebKit/Source/platform/heap/heap/StackFrameDepth.obj
FAILED: obj/third_party/WebKit/Source/platform/heap/heap/StackFrameDepth.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  @obj/third_party/WebKit/Source/platform/heap/heap/StackFrameDepth.obj.rsp /c ../../third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp /Foobj/third_party/WebKit/Source/platform/heap/heap/StackFrameDepth.obj /Fd"obj/third_party/WebKit/Source/platform/heap/heap_cc.pdb"
In file included from ../../third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp:8:
In file included from ../../third_party/WebKit\public/platform/Platform.h:55:
In file included from ../../third_party/WebKit\public/platform/WebURLError.h:37:
../..\services/network/public/cpp/cors_error_status.h(10,10):  fatal error: 'services/network/public/interfaces/cors.mojom-shared.h' file not found
#include "services/network/public/interfaces/cors.mojom-shared.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Heap target is missing dependency on //third_party/WebKit/public:blink_headers.

Comment 1 by mharanc...@opera.com, Dec 12 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6d2e794493949fe18482657e513691397ee9e95

commit d6d2e794493949fe18482657e513691397ee9e95
Author: Marek Haranczyk <mharanczyk@opera.com>
Date: Wed Dec 13 12:07:50 2017

Add missing blink_header dep to //third_party/WebKit/Source/platform/heap.

Bug:  794207 
Change-Id: Icc7a0654a643c53ecc6cd68d2c3a73e6bd394a81
Reviewed-on: https://chromium-review.googlesource.com/823030
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523749}
[modify] https://crrev.com/d6d2e794493949fe18482657e513691397ee9e95/third_party/WebKit/Source/platform/heap/BUILD.gn

Comment 3 by mharanc...@opera.com, Dec 13 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment