Log RankerExample float and string values in UKM for AssistRanker |
||
Issue descriptionWe need to implement a float/string to int conversion so that we can log these features through UKM in ranker_example_util. We also need to implement the corresponding decoding on the server side when we read the logs.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/100d8c76497f67dac11dc994d1bb6078f23e9261 commit 100d8c76497f67dac11dc994d1bb6078f23e9261 Author: Charles Zhao <charleszhao@chromium.org> Date: Thu Jan 18 00:23:25 2018 Add LogExampleToUkm support for float_value, string_val and string_list. (1) Changed FeatureToInt to FeatureToInt64 to also includes feature_type_case and index (for string_list) info. string is hashed to int32 and float is bit_casted to int32. (2) Changed LogFeatureToUkm to support float_value, string_val and string_list. (3) Also add relevant tests. Bug: 794187 Change-Id: Id162d2264ba2b01d84188254a5fef7f11db8cc74 Reviewed-on: https://chromium-review.googlesource.com/859398 Reviewed-by: Philippe Hamel <hamelphi@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#529974} [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/base_predictor.cc [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/base_predictor_unittest.cc [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/proto/ranker_example.proto [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/ranker_example_util.cc [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/ranker_example_util.h [modify] https://crrev.com/100d8c76497f67dac11dc994d1bb6078f23e9261/components/assist_ranker/ranker_example_util_unittest.cc
,
Aug 9
|
||
►
Sign in to add a comment |
||
Comment 1 by charleszhao@chromium.org
, Jan 10 2018