New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794177 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

devicechange event broken

Project Member Reported by guidou@chromium.org, Dec 12 2017

Issue description

The devicechange event is not fired when devices are added or removed.
Tested on 64.0.3282.14 and ToT on Win, Mac and Linux.

The following error message is logged:
[204417:204455:1212/170400.823666:ERROR:service_manager.cc(158)] Connection InterfaceProviderSpec prevented service: content_browser from binding interface: blink::mojom::MediaDevicesListener exposed by: content_renderer

This is caused by r522772
 

Comment 1 by guidou@chromium.org, Dec 12 2017

Labels: ReleaseBlock-Stable ReleaseBlock-Beta

Comment 2 by guidou@chromium.org, Dec 12 2017

Working on a patch.

Comment 3 by guidou@chromium.org, Dec 12 2017

Labels: M-64
Hi Guido,

We're targeting a new RC build tonight that will be used for beta.  Chance this can be patched and merged asap?   Thanks


Comment 5 by gkihumba@google.com, Dec 12 2017

What's the user-effect of this issue?

Comment 6 by guidou@chromium.org, Dec 12 2017

It breaks applications relying on the devicechange event, which is fired when an audio or video device (i.e, webcam) is added or removed from the system.

Comment 7 by gkihumba@google.com, Dec 12 2017

Ok, sounds like a beta blocker. Do you have ETA for the patch?

Comment 8 by guidou@chromium.org, Dec 12 2017

It's about to land.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fee6fdeaef1de2f46c34ed3143d56cc672ed69f1

commit fee6fdeaef1de2f46c34ed3143d56cc672ed69f1
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Dec 12 19:05:48 2017

Update the name of the MediaDevicesListener mojo interface name

A previous CL that moved some of the functionality to Blink missed this,
which prevents firing of the devicechange event.

Bug:  794177 
Change-Id: I5ab74f5605979ec508c0620d75eb41585b32f218
Reviewed-on: https://chromium-review.googlesource.com/822259
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523500}
[modify] https://crrev.com/fee6fdeaef1de2f46c34ed3143d56cc672ed69f1/content/public/app/mojo/content_renderer_manifest.json

Labels: Merge-Request-64
Requesting merge to M64. The fix is a one-line change in a configuration file. 
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 12 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e1e58c382e599dc8c8a41ad54a101bf0285358

commit e9e1e58c382e599dc8c8a41ad54a101bf0285358
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Dec 12 19:37:41 2017

Update the name of the MediaDevicesListener mojo interface name

A previous CL that moved some of the functionality to Blink missed this,
which prevents firing of the devicechange event.

Bug:  794177 
Change-Id: I5ab74f5605979ec508c0620d75eb41585b32f218
Reviewed-on: https://chromium-review.googlesource.com/822259
Reviewed-by: Chandan Padhi <c.padhi@samsung.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523500}(cherry picked from commit fee6fdeaef1de2f46c34ed3143d56cc672ed69f1)
Reviewed-on: https://chromium-review.googlesource.com/822531
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#179}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/e9e1e58c382e599dc8c8a41ad54a101bf0285358/content/public/app/mojo/content_renderer_manifest.json

Status: Fixed (was: Assigned)

Sign in to add a comment