Newly created bookmark folder is editable after dismissing the keyboard |
||||
Issue descriptionApp Version: 65.0.3292.0 Canary iOS Version: 10.3.3, 11.2 Device: iPad only Steps to reproduce: 1. Launch chrome and open bookmarks 2. Go to mobile bookmarks 3. Tap on the new folder button 4. Tap on dismiss keyboard button 5. Tap gentle on the bookmark folder text Observed results: Notice that keyboard displays and user is able to edit the bookmark folder Expected results: On tapping dismiss bookmarks folder name should be created and it shouldn’t be editable any more. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M63 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M64 Link to video/image: https://drive.google.com/file/d/15hR4rzp2CpQWlrJfAdFTT_-lbHdAb60U/view?usp=sharing
,
Dec 14 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54857f4351ae59436f7a7363204b6b6bca309140 commit 54857f4351ae59436f7a7363204b6b6bca309140 Author: Marti Wong <martiw@chromium.org> Date: Thu Dec 14 14:14:40 2017 Fix the new bookmark folder name issue on iPad when keyboard dismiss. Fix the issue that when editing the new folder name on iPad and tap on the 'hide keyboard' button, the folder name is supposed to commit but doesn't. An egtest is added to prevent this bug from happening again. Bug: 794155 Change-Id: Ie0ef4c1af7f87c55051876bd08331c5d0a0e40a8 Reviewed-on: https://chromium-review.googlesource.com/826585 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#524058} [modify] https://crrev.com/54857f4351ae59436f7a7363204b6b6bca309140/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm [modify] https://crrev.com/54857f4351ae59436f7a7363204b6b6bca309140/ios/chrome/browser/ui/bookmarks/cells/bookmark_table_cell.mm
,
Dec 15 2017
,
Dec 19 2017
Verified on chrome canary version 65.0.3299.0 on iPad Air with iOS 11.2, iPad Pro with iOS 10.3.3, following the steps mentioned in comment #0. After dismissing the keyboard the folder is not editable. Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sczs@chromium.org
, Dec 13 2017Status: Assigned (was: Untriaged)