[Dice] Crash when closing tab during signin |
||||
Issue descriptionPotential crash discovered while writing tests: https://chromium-review.googlesource.com/c/chromium/src/+/817596/1/chrome/browser/signin/process_dice_header_delegate_impl.cc#b105
,
Dec 13 2017
,
Dec 14 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81acd5618cb6fc013d04feef3e9e36c3adb6d34c commit 81acd5618cb6fc013d04feef3e9e36c3adb6d34c Author: David Roger <droger@chromium.org> Date: Thu Dec 14 13:53:46 2017 [signin] Add unittest for ProcessDiceHeaderDelegateImpl This CL fixes a crash happening when the signin tab is closed during the signin process. This CL also adds unittests for the class. TBR=droger@chromium.org (cherry picked from commit 17e9032193fd9c06b12fcd44c068e8f17ac7c445) Bug: 794152 Change-Id: I9c0c1faec7e2a9e564dc35f1b76eb2fa4f8d9bb7 Reviewed-on: https://chromium-review.googlesource.com/817596 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523433} Reviewed-on: https://chromium-review.googlesource.com/827019 Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#226} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/81acd5618cb6fc013d04feef3e9e36c3adb6d34c/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/81acd5618cb6fc013d04feef3e9e36c3adb6d34c/chrome/browser/signin/process_dice_header_delegate_impl.cc [modify] https://crrev.com/81acd5618cb6fc013d04feef3e9e36c3adb6d34c/chrome/browser/signin/process_dice_header_delegate_impl.h [add] https://crrev.com/81acd5618cb6fc013d04feef3e9e36c3adb6d34c/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc [modify] https://crrev.com/81acd5618cb6fc013d04feef3e9e36c3adb6d34c/chrome/test/BUILD.gn |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 12 2017