New issue
Advanced search Search tips

Issue 794136 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 724392
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 809408



Sign in to add a comment

Some css-multicol tests are flaky on Win7 Tests (dbg)(1)

Project Member Reported by mstensho@chromium.org, Dec 12 2017

Issue description

Some wpt multicol tests were marked as flaky with https://chromium-review.googlesource.com/c/chromium/src/+/817748

Only happened on Win7 Tests (dbg)(1) [1], as far as I know, and no layout test results are saved with that bot. So pretty hard to know what's going on. Could have to do with the Ahem font [2], but then again, there are many wpt tests that use Ahem.

List of flaky tests:
external/wpt/css/css-multicol/multicol-fill-balance-001.xht
external/wpt/css/css-multicol/multicol-gap-negative-001.xht
external/wpt/css/css-multicol/multicol-overflow-000.xht
external/wpt/css/css-multicol/multicol-overflowing-001.xht
external/wpt/css/css-multicol/multicol-rule-002.xht
external/wpt/css/css-multicol/multicol-rule-shorthand-2.xht
external/wpt/css/css-multicol/multicol-rule-stacking-001.xht
external/wpt/css/css-multicol/multicol-width-001.xht

[1] https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 (Googlers only)
[2] See third_party/WebKit/LayoutTests/resources/ahem.js , which is used many non-wpt tests to make Ahem work better on Windows.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22925f307e891ac5184b3258a56b9347098d810

commit c22925f307e891ac5184b3258a56b9347098d810
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 12 13:18:42 2017

Associate remaining wpt multicol tests with dedicated bug reports.

Bug:  788337 , 776051 ,792435,792437,636055,792446, 794136 
Change-Id: I933ece936b79323bfcdf16cc96fd3475f42349f6
Reviewed-on: https://chromium-review.googlesource.com/822254
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523416}
[modify] https://crrev.com/c22925f307e891ac5184b3258a56b9347098d810/third_party/WebKit/LayoutTests/TestExpectations

Cc: robertma@chromium.org qyears...@chromium.org foolip@chromium.org
 Issue 796733  has been merged into this issue.
Blockedon: 809408
I don't dare to reland this unless we get the bot to behave.
Cc: mstensho@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df22bb027548a30b947e0bce39b3b829ad2aa37e

commit df22bb027548a30b947e0bce39b3b829ad2aa37e
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed Feb 28 10:34:01 2018

[css-multicol] Use "Ahem" instead of "ahem" in tests

"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on WPT tests.

BUG= 724392 , 794136 

Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb
Reviewed-on: https://chromium-review.googlesource.com/940921
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539780}
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-002.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-fraction-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-fraction-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-px-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-shorthand-2-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-shorthand-2.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-stacking-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-stacking-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-shorthand-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-block-sibling-003.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-block-sibling-3-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-firstchild-ref.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-001.xht
[modify] https://crrev.com/df22bb027548a30b947e0bce39b3b829ad2aa37e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-ref.xht

Comment 6 by r...@igalia.com, Feb 28 2018

Mergedinto: 724392
Owner: r...@igalia.com
Status: Duplicate (was: Available)
The problem here was that the tests were using "ahem" instead of "Ahem".
That should work fine but there's some bug on Windows see  issue #724392 .

Sign in to add a comment