New issue
Advanced search Search tips

Issue 794128 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Win10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 12 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@google.com

webkit_layout_tests failing on chromium.webkit/WebKit Win10

Builders failed on: 
- WebKit Win10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10


 
Failing test is http/tests/inspector-protocol/network/raw-headers-for-protected-document.js

suspect is
https://chromium-review.googlesource.com/c/chromium/src/+/821410
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f08a3d4d749313f5ca1178aac0d0eae7ddf73f

commit 40f08a3d4d749313f5ca1178aac0d0eae7ddf73f
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Dec 12 11:12:47 2017

Revert "DevTools: do not report raw headers and cookies for protected subresources."

This reverts commit 6745e12dc9b3313294a80575a4284f64ec175d88.

Reason for revert: Test raw-headers-for-protected-document.js is flaky (mostly failing)

Original change's description:
> DevTools: do not report raw headers and cookies for protected subresources.
>
> In case subresource request's site needs to have its document protected, don't
> send raw headers and cookies into the frame's renderer.
>
> Bug:  793692 
> Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969
> Reviewed-on: https://chromium-review.googlesource.com/821410
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523364}

TBR=creis@chromium.org,pfeldman@chromium.org

Change-Id: I2f4abad2167c23cf6218fe1806eeadb212ccb430
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  793692 , 794128 
Reviewed-on: https://chromium-review.googlesource.com/822190
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523400}
[modify] https://crrev.com/40f08a3d4d749313f5ca1178aac0d0eae7ddf73f/content/browser/loader/resource_dispatcher_host_impl.cc
[delete] https://crrev.com/9e3ea37af709a9b7e9ae5331744dd7a1c97a2ce3/third_party/WebKit/LayoutTests/flag-specific/site-per-process/http/tests/inspector-protocol/network/raw-headers-for-protected-document-expected.txt
[delete] https://crrev.com/9e3ea37af709a9b7e9ae5331744dd7a1c97a2ce3/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-headers-for-protected-document-expected.txt
[delete] https://crrev.com/9e3ea37af709a9b7e9ae5331744dd7a1c97a2ce3/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
[delete] https://crrev.com/9e3ea37af709a9b7e9ae5331744dd7a1c97a2ce3/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/cookie.pl

Cc: pfeldman@chromium.org
Labels: -Sheriff-Chromium OS-Windows
Owner: pfeldman@chromium.org
Status: Assigned (was: Available)
Assigned to the author of the test
Status: Fixed (was: Assigned)

Sign in to add a comment