New issue
Advanced search Search tips

Issue 794123 link

Starred by 1 user
Status: Fixed
Owner:
hajimehoshi@chromium.org
Closed: Dec 2017
Cc:
skyos...@chromium.org
altimin@chromium.org
haraken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Replace TTRH/STRH::Get() usages in renderer tests with GetForTesting()

Project Member Reported by hajimehoshi@chromium.org, Dec 12 2017 
We aim to remove all the usages of ThreadTaskRunnerHandle/SequencedTaskRunnerHandle::Get in renderer. As one of the steps,

* Introduce TTRH/STRH::GetForTesting()
* Replace all Get() with GetForTesting() in all renderer tests

Thus, this is just renaming, but we will be able to forbid Get() usages with presubmit.py in the future.

Doc: https://docs.google.com/document/d/1n9qNbP0H28J4DIzorydemc36b1xy-8-5zEADsoJfMxU/edit#heading=h.yqd0rv2o92v1

Comment 1 by hajimehoshi@chromium.org, Dec 12 2017

Owner: hajimehoshi@chromium.org
Status: Started (was: Untriaged)

Comment 2 by hajimehoshi@chromium.org, Dec 12 2017

Summary: Replace TTRH/STRH::Get() usages in renderer tests with GetForTesting() (was: Replace TTRH/STRH::Get() usages in tests with GetForTesting())
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7faf13dda12739205577aa4a319ddbf61370b3

commit fd7faf13dda12739205577aa4a319ddbf61370b3
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Dec 14 08:32:24 2017

Introduce blink::TaskType::kInternalTest

We plan to deprecate kUnspecedTimer / kUnspecedLoading / kUnthrottled
and introduce kInternal* for internal usages.

This CL introduces kInternalTest for tests or mock objects and replaces
the current task types with kInternalTest.

Doc: https://docs.google.com/document/d/1n9qNbP0H28J4DIzorydemc36b1xy-8-5zEADsoJfMxU/edit#

Bug:  794123 
Change-Id: If4e616d9b770ff0e5be88261e68c3fd572d05783
Reviewed-on: https://chromium-review.googlesource.com/822792
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524024}
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/content/shell/test_runner/pixel_dump.cc
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/fd7faf13dda12739205577aa4a319ddbf61370b3/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/209b62b41be08f1c6f254b7cda78c3138e7e1846

commit 209b62b41be08f1c6f254b7cda78c3138e7e1846
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Dec 19 06:51:02 2017

content/renderer, third_party/WebKit: Replace TTRH::Get() with Get*TaskRunnerForTesting()

We aim to deprecate ThreadTaskRunnerHandle::Get() (and
SequencedTaskRunnerHandle::Get()) in renderer and use per-frame
schedulers as much as possible instaed.

However, in tests, it is not feasible to use per-frame task runners
instead of TTRH::Get(). Instead of deprecating, this CL renames Get
with Get*TaskRunnerForTesting so that we will be able to deprecate
Get() usages in renderer in the future.

This CL just replaces them only in content/renderer and
third_party/WebKit. This doesn't cover all of renderer and we plan to
apply this change in other components of renderer in the future.

Bug:  794123 
Change-Id: I2fd01f841c4f78c2d32f9d6e39c82f96a0c5eed7
Reviewed-on: https://chromium-review.googlesource.com/822350
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524959}
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/device_sensors/device_motion_event_pump_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/loader/web_data_consumer_handle_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/android/stream_texture_wrapper_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/media_stream_video_capturer_source_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/peer_connection_tracker_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/peer_connection_dependency_factory_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media/webrtc/webrtc_set_remote_description_observer_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/media/blink/video_decode_stats_reporter_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/Source/platform/scheduler/DEPS
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/209b62b41be08f1c6f254b7cda78c3138e7e1846/third_party/WebKit/public/platform/scheduler/test/renderer_scheduler_test_support.h
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a8599d2d410b1c7920504e6e5ce12a668c979b2

commit 9a8599d2d410b1c7920504e6e5ce12a668c979b2
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Dec 19 11:31:42 2017

Fix wrong comment at lazy_thread_controller_for_test.cc

The comment was updated at https://chromium-review.googlesource.com/c/chromium/src/+/822350
mistakenly. This CL corrects this.

Bug:  794123 
Change-Id: I84ba6be1c00f79880a2e63c6bce9c7a4e5448167
Reviewed-on: https://chromium-review.googlesource.com/833442
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524999}
[modify] https://crrev.com/9a8599d2d410b1c7920504e6e5ce12a668c979b2/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc

Comment 6 by hajimehoshi@chromium.org, Dec 21 2017

Status: Fixed (was: Started)
►

Sign in to add a comment