Hard to find a password on Android if you have lots of them |
||||||||||||||
Issue descriptionChrome Version: 62 OS: Android What steps will reproduce the problem? (1) Have a huge number of stored passwords (2) Try to find the password for example.com What is the expected result? It should be easy to find stored passwords for a site. I sometimes try to do this if the password is either not suggested correctly or I need it for a different purpose than the site it is stored for. (not in Chrome or on a different domain) What happens instead? I have difficulties finding passwords for a site. Maybe the password list could be improved to make it easier to look up passwords? There is no search functionality for the password list. The list of passwords is a list of origins that are sorted by registrable domain. This is a bit confusing and makes it hard to parse entries while scrolling through the list. Maybe it would help if the subdomain part was grey? There doesn't seem to be a direct way to get from a site to stored passwords for this site?
,
Dec 12 2017
+maxwalker for proposal to make subdomain part gray.
,
Dec 12 2017
I completely agree that the current alphabetical sorting is unclear (Android and Desktop sort by eTLD+1, iOS sorts by hostname) and that search functionality would be useful. Making the subdomain grey doesn't seem ideal to me because it makes the list more noisy (see attached image). I created a proposal for grouping items by eTLD+1 (and one for a search feature), also based on these additional thoughts: - People typically remember and search for sites by eTLD+1, e.g. “spotify.com” instead of “accounts.spotify.com”. - Listing each hostname results in more entries, so the list becomes harder to parse. Search proposal: https://goo.gl/thJuem (Google internal) Grouping proposal: https://goo.gl/BK2dH5 (Google internal) WDYT about implementing these instead? Thanks
,
Jan 8 2018
,
Jan 8 2018
,
Jan 8 2018
I would start with search: go/android-password-search. 1. This also simplifies finding a password if you are unaware of the domain: e.g. playstation.com redirects to id.sonyentertainmentnetwork.com/signin for authentication. If you want to enter the password on your console, autofill won't work and you would have to go through the entire list. Searching for "playstation", "psn" and "sony" allows to quickly filter and speed up this process. 2. Android apps are usually stored by name. You don't have to remember the full name to find one (e.g. "Nokia Health Mate" could be found by searching for just a substring).
,
Jan 8 2018
,
Jan 19 2018
The attached video is a recording of https://crrev.com/c/866830/19
,
Jan 19 2018
Looks great!
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03c9198815cc223325fd43182a7121de6f85b01e commit 03c9198815cc223325fd43182a7121de6f85b01e Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Jan 25 14:21:28 2018 Add search bar to Android password settings By enabling the feature PasswordSearch, a search icon will appear in the action bar in Chrome > Settings > Save Passwords. Clicking the icon will trigger a search box that hides non-password views. Every newly typed letter will instantly filter passwords which don't contain the query. Ignores case. Update: instead of adding a new white icon, the ic_search is recolored. Update: merged with WIP crrev/c/868213 Bug: 794108 Change-Id: I9b4e3c7754bb5b0cc56e3156a746bcbf44aa5bd3 Reviewed-on: https://chromium-review.googlesource.com/866830 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531891} [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/android/java/res/menu/save_password_preferences_action_bar_menu.xml [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/browser/about_flags.cc [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/components/password_manager/core/common/password_manager_features.cc [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/components/password_manager/core/common/password_manager_features.h [modify] https://crrev.com/03c9198815cc223325fd43182a7121de6f85b01e/tools/metrics/histograms/enums.xml
,
Jan 26 2018
Search on Android is feature complete and can be tested on Trunk builds using the #password-search flag in Chrome flags. Visuals haven't changed since #9. Track the rollout of the search in issue 805426.
,
Jan 30 2018
Before this can be considered fixed (even after launch), it should be robust under memory pressure ( issue 807306 ) and look nicely on large screens (isssue 807303).
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af8b8de8fb55210836de65b9667bcd97ff4c93d1 commit af8b8de8fb55210836de65b9667bcd97ff4c93d1 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Feb 05 12:06:56 2018 Add metrics for password search on Android This CL adds two metrics letting us know how users use the password search feature (go/android-password-search): 1. "ViewedAfterSearched" as new enum value on PasswordManager.Android.PasswordCredentialEntry capturing the number of passwords that were clicked as a search result. This happens in addition to the existing "Viewed" bucket. 2. PasswordManager.Android.PasswordSearchTriggered recording how many users who opened a the preferences triggered the search. Bug: 794108 Change-Id: Ib1bcc2c1080ee196ea6634007726e572a6305b65 Reviewed-on: https://chromium-review.googlesource.com/893267 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534369} [modify] https://crrev.com/af8b8de8fb55210836de65b9667bcd97ff4c93d1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java [modify] https://crrev.com/af8b8de8fb55210836de65b9667bcd97ff4c93d1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/af8b8de8fb55210836de65b9667bcd97ff4c93d1/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java [modify] https://crrev.com/af8b8de8fb55210836de65b9667bcd97ff4c93d1/tools/metrics/histograms/enums.xml [modify] https://crrev.com/af8b8de8fb55210836de65b9667bcd97ff4c93d1/tools/metrics/histograms/histograms.xml
,
Feb 12 2018
,
Feb 13 2018
This screencast shows the flow for the reworked search input field (more similar to the Site Settings Page now). The screenshot shows the right-aligned position (LTR devices) of the search view.
,
Mar 8 2018
,
Mar 9 2018
,
Mar 14 2018
,
Mar 15 2018
,
Mar 15 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59fe2993c8c468dc65d60c3360a4044750e1ce99 commit 59fe2993c8c468dc65d60c3360a4044750e1ce99 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Fri Apr 06 16:16:42 2018 Enable PasswordSearch feature by default As we have all approvals and the feature will fully launch with 66, enable it by default. Bug: 794108 Change-Id: I2cc5badc77391ff8bfe56b8653381c3648fd06a7 Reviewed-on: https://chromium-review.googlesource.com/999516 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#548797} [modify] https://crrev.com/59fe2993c8c468dc65d60c3360a4044750e1ce99/components/password_manager/core/common/password_manager_features.cc |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by battre@chromium.org
, Dec 12 2017Status: Available (was: Untriaged)