New issue
Advanced search Search tips

Issue 794089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup OffMainThreadFetch flag

Project Member Reported by horo@chromium.org, Dec 12 2017

Issue description

We have shipped OffMainThreadFetch in M62 ( issue 443374 ).


We don't need this flag anymore.
We should remove it for the code health.
 

Comment 1 by horo@chromium.org, Dec 12 2017

WIP patch: https://crrev.com/c/822016
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2

commit c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri Dec 15 13:48:30 2017

Cleanup OffMainThreadFetch flags

Bug:  794089 
Change-Id: If6c0093d6fcea03aa57ea8f8dd9b089765f0ede5
Reviewed-on: https://chromium-review.googlesource.com/822016
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524372}
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/chrome/browser/about_flags.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/chrome/browser/subresource_filter/subresource_filter_worker_browsertest.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/components/subresource_filter/content/renderer/subresource_filter_agent.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/child/runtime_features.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/public/common/content_features.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/public/common/content_features.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/loader/ThreadableLoader.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/public/web/WebSharedWorkerClient.h
[modify] https://crrev.com/c3948ad2a1fbed8b5b538dee9bbfab52bbe64ec2/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee9515cb0b592bc9b993cc9b1360efa61bd87c3

commit 4ee9515cb0b592bc9b993cc9b1360efa61bd87c3
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Dec 15 17:09:49 2017

Fix filter for renamed tests

r524372 renamed a number of tests from WorkerFetchTest.* to WorkerTest.*
and removed parameterization for the OffMainThreadFetch feature. This
change updates the filters for network_content_browsertests to match.

Bug:  794089 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ia7b44629161a71d66787477c6077cb26712ecb19
No-Try: true
No-Presubmit: true
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/829974
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524399}
[modify] https://crrev.com/4ee9515cb0b592bc9b993cc9b1360efa61bd87c3/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 4 by horo@chromium.org, Dec 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment