New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794086 link

Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Regression:(Win-10)-Screen blackouts and unable to uninstall.

Reported by aiman.an...@etouch.net, Dec 12 2017

Issue description

Chrome Version: 65.0.3292.0 (Official Build) (64-bit) (cohort: 63_win_84) 7d40cf8237fbf29b3dffb6dca3376c10c3df176b-refs/heads/master@{#523290}

OS:Win(10)
Steps to reproduce:
1. Launch chrome and observe.

Actual Result:Black screen is seen and unable to uninstall
Expected Result: Should not blackout and should uninstall

This is regression issue broken in ‘M-65’ and and below is the bisect info

Using the per-revision bisect providing the bisect results,
Good build:65.0.3291.0
Bad build:65.0.3292.0
 
Labels: hasbisect-per-revision OS-Windows
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Summary: Regression:(Win-10)-Screen blackouts and unable to uninstall. (was: Regression:Screen blackouts and unable to uninstall)
Using the per-revision bisect providing the bisect results,
Good build:65.0.3291.0(Revision:523022)
Bad build:65.0.3292.0(Revision:523290)

You are probably looking for a change made after 523207 (known good), but no later than 523208 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0838f4e2e35bf60ad6151d4609464941f6aa55c9..e2f749cf36505b9c8b5fbcb9e80d95e6c12081b0

Suspect:https://chromium.googlesource.com/chromium/src/+/0838f4e2e35bf60ad6151d4609464941f6aa55c9

@rsesek:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Above issue is only for Win-10 OS

Thank You!
Actual Result.png
25.5 KB View Download
 Issue 794100  has been merged into this issue.
Components: -OS>Installer Internals>Installer UI
Labels: ReleaseBlock-Dev
Adding RB Dev as this is a recent Regression. Please remove if not required.
Thank You.
Labels: -Pri-1 Pri-0
Changing the Priority to P0 as this is blocking today's Canary.
Thank You.

Comment 6 by qwer1...@gmail.com, Dec 12 2017

Is there a workaround?

Comment 7 by rsesek@chromium.org, Dec 12 2017

Cc: sadrul@chromium.org rsesek@chromium.org fsam...@chromium.org liyuqian@chromium.org khushals...@chromium.org
Owner: cwallez@chromium.org
I cannot reproduce this in a VM or on my GCE instance, which makes me think it's related to graphics acceleration. I had a coworker try on their dedicated Windows machine (i.e. with a real GPU), and they were able to reproduce the issue. What's interesting is that they were able to hover around where the Omnibox is, get an I insertion cursor, and type into the omnibox and navigate, though the window was still black.

Looking through the full changelog https://chromium.googlesource.com/chromium/src/+log/65.0.3291.0..65.0.3292.0?pretty=fuller&n=10000 there are a couple of graphics related changes that may have affected this:

Roll src/third_party/angle/ 9b88991c7..c7abc0803 https://chromium.googlesource.com/chromium/src/+/e2f749cf36505b9c8b5fbcb9e80d95e6c12081b0 
mus/aura: Embed windows should have valid LocalSurfaceId. https://chromium.googlesource.com/chromium/src/+/4864aaae6923e2970a96bdaaf33146568acb07ae
Fix surface resurrection when CompositorFrameSink recreated https://chromium.googlesource.com/chromium/src/+/3ce021b7efd176e818f005373dce3bde181a27a2
Roll src/third_party/skia/ c34676349..2326177e3 https://chromium.googlesource.com/chromium/src/+/5b12f5d309bff5eada8110b4c4ecd823549b38b0
cc: Change heuristics for prioritizing impl-side invalidations. https://chromium.googlesource.com/chromium/src/+/17b77d94eb6f27e6cac263969fe9999522f2ade2
mus/aura: Fix setting up LayerTreeFrameSink for a window. https://chromium.googlesource.com/chromium/src/+/d04afb748bd39048c0a27556fcbcdf86f080bc7b

Given that the bisect in #1 pinpoints the angle roll, starting there.
Thanks for the heads up. The only patch in the ANGLE roll does a changes mostly Mac stuff but tweaks a bit of validation that on Win10 is related to DXGI surfaces. So it is definitely suspect. Revert is in the CQ.

Unfortunately coworkers with Win10 machines are OOO today so I'm not able to confirm this fixes the issues.

Comment 9 by cbruni@chromium.org, Dec 12 2017

 Issue 794167  has been merged into this issue.

Comment 11 by lfg@chromium.org, Dec 12 2017

Cc: gov...@chromium.org
+govind@ We need to respin canary once the revert has landed.

Cc: ligim...@chromium.org
Pls merge the revert to latest canary branch #3292 once it lands.

Comment 13 by lfg@chromium.org, Dec 12 2017

cwallez: I can confirm that your revert fixes the problem on my local Win10 build.
Revert landed in 3292 as https://chromium.googlesource.com/chromium/src/+/e950471e48c01225bfbe5731b0d3b8e8e2c75e64

I'll let you close this when the canary as be respun.
Triggered new windows canary from 3292 branch. 
 Issue 794175  has been merged into this issue.
Successfully released 65.0.3292.3 to windows canary.
Cc: -liyuqian@chromium.org

Comment 19 by pcgo...@gmail.com, Dec 12 2017

65.0.3292.3 is still broken.
Looks like it didn't get the change (Still "ANGLE commit id c7abc08034a3" in chrome://gpu)
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3acfc6255c56069ffa9373d03f6215e3bddd8084

commit 3acfc6255c56069ffa9373d03f6215e3bddd8084
Author: Corentin Wallez <cwallez@chromium.org>
Date: Tue Dec 12 22:59:42 2017

Add test for Chromium's EGL_D3D_TEXTURE pbuffer creation

When creating the pbuffer, Chromium specifies EGL_WIDTH and EGL_HEIGHT
attributes that are unnecessary because they are extracted from the
D3D11 texture passed as <buffer> to eglCreatePbufferFromClientBuffer.

This is a regression test for  crbug.com/794086  where a change to
ValidateCreatePbufferFromClientBuffer made EGL_WIDTH and EGL_HEIGHT
invalid for <buftype> EGL_D3D_TEXTURE and caused Chromium to fail
creating the pbuffer, causing all black rendering.

BUG= chromium:794086 

Change-Id: I262fd0991e0f46f255aeac25528ddb4a62fa1309
Reviewed-on: https://chromium-review.googlesource.com/822296
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/3acfc6255c56069ffa9373d03f6215e3bddd8084/src/tests/gl_tests/D3DTextureTest.cpp

aiman.ansari@ please verify the fix once canary is available.
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/23b3997937adbc201de7633567924054e03e1c4d

commit 23b3997937adbc201de7633567924054e03e1c4d
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Tue Dec 12 23:56:09 2017

Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/a98a28112b0e..3acfc6255c56

$ git log a98a28112..3acfc6255 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 cwallez Add test for Chromium's EGL_D3D_TEXTURE pbuffer creation

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 794086 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=liyuqian@google.com

Change-Id: I727f879da489bda6c2744db7542356c05cb42c2d
Reviewed-on: https://skia-review.googlesource.com/84169
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/23b3997937adbc201de7633567924054e03e1c4d/DEPS

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/228d8a973f6211c471c0375353f2446189ce9f27

commit 228d8a973f6211c471c0375353f2446189ce9f27
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Tue Dec 12 23:56:11 2017

Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/a98a28112b0e..3acfc6255c56

$ git log a98a28112..3acfc6255 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 cwallez Add test for Chromium's EGL_D3D_TEXTURE pbuffer creation

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 794086 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE
TBR=liyuqian@google.com

Change-Id: I72e46a888d8b9e12d7342db92e6851a74e0bf48c
Reviewed-on: https://skia-review.googlesource.com/84168
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>


Labels: Hotlist-ConOps
Still not working on my Win10 machine

Comment 26 by qwer1...@gmail.com, Dec 13 2017

Same here: not working on Win 10 64b on hp Spectre 360
Labels: TE-Verified-M65 TE-Verified-65.0.3293.0
Hi,
Retested the above issue on Windows 10 latest Canary 65.0.3293.0 and fix is working as intended.

Thanks!
Current Result.png
60.1 KB View Download
With the following version it's not working on my machine

Google Inc.
Copyright 2017 Google Inc. Alle Rechte vorbehalten.
Google Chrome	65.0.3292.3 (Offizieller Build) canary (64-Bit) (cohort: Clang-64)
Überarbeitung	d83669fac9c4787125649a6b363f5036c1806ccf-refs/branch-heads/3292@{#4}
Betriebssystem	Windows

Comment 29 by qwer1...@gmail.com, Dec 13 2017

I can confirm that with Version 65.0.3293.0 (Official Build) canary (64-bit) problem's solved
mee too

Comment 31 by lfg@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
Verified on 65.0.3293.
Cc: abdulsyed@chromium.org
 Issue 794648  has been merged into this issue.

Sign in to add a comment