Issue metadata
Sign in to add a comment
|
Regression : Slight delay is seen after removing extension from omnibox.
Reported by
rp...@etouch.net,
Dec 12 2017
|
||||||||||||||||||||||
Issue descriptionVersion: 64.0.3282.24 b0ff7139cae6db3e8c340bea7a081b73d00a342c-refs/branch-heads/3282@{#161} OS: Mac OS X(10.12.6,10.13.2) URL : https://chrome.google.com/webstore/detail/yesware-email-tracking/gkjnkapjmjfpipfcccnjbjcbgdnahpjp/related?utm_source=chrome-ntp-icon Pre condition : Enable Material Design in the rest of the browser's native UI flag from chrome://flags What steps will reproduce the problem? 1. Launch chrome, navigate to above url and add extension. 2. Now remove added extension by right clicking on extension icon and observe omnibox behavior after removing it Actual: Slight delay is seen after removing extension from omnibox Expected: Delay should not be seen after removing extension from omnibox This is regression issue, broken in ‘M 64’ and will below is the bisect info : Good build: 64.0.3260.0 (Revision: 514067). Bad build: 64.0.3261.0 (Revision: 514329). You are probably looking for a change made after 514134(known good), but no later than 514135(first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0ecbf11291583df087194bf122a7b109868669fc..898669974e9ce0867e3dc80fe9385de8983a77ce From the CL above, assigning the issue to the concern owner @krb- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Suspect : https://chromium.googlesource.com/chromium/src/+/898669974e9ce0867e3dc80fe9385de8983a77ce Thanks! Note : Issue is not seen on Linux and Windows OS.
,
Dec 12 2017
,
Dec 12 2017
This doesn't seem possible. See here where the sole addition is hidden behind a feature flag: https://chromium.googlesource.com/chromium/src/+/898669974e9ce0867e3dc80fe9385de8983a77ce%5E%21/#F12 Are there really no other differences between these two versions? When I do that diff, I see 4413 files changed, 805 with the string "ext" in the name.
,
Dec 14 2017
,
Dec 14 2017
,
Dec 20 2017
rpise@etouch.net: can you clarify what you mean by "slight delay is seen"? Delay before what, precisely? I'm having a hard time noticing any difference between your two videos. Is it that there's a very small amount of time before the omnibox resizing (growing) animation starts when the extension icon disappears?
,
Dec 20 2017
,
Dec 21 2017
With response to comment #6 : Yes there's a very small amount of time before the omnibox resizing (growing) animation starts when the extension icon disappears.
,
Jan 11 2018
Looking again at the diff'd files, perhaps relevant? https://chromium-review.googlesource.com/c/chromium/src/+/752262
,
Mar 7 2018
I have a feeling the new animation might be intentional. Assigning to ellyjones@ who would presumably know for sure.
,
Mar 7 2018
The linked CL in #9 isn't related. As far as I know, we didn't change this deliberately, but it can happen if it takes us a moment to remove the extension - you can see a similar delay when adding the extension before we insert the new icon. Maybe we should speed up the visuals, but I doubt that this was a recent regression.
,
Mar 7 2018
Comparing the two screen recordings, it seems like the change is MacViews?
,
Mar 7 2018
,
Mar 7 2018
,
Mar 23 2018
MacViews triage: we aren't likely to address this before we ship MacViews-Browser, so WontFix. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rp...@etouch.net
, Dec 12 2017