New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794079 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blank window is seen after launching Hangout

Reported by nutan.ga...@etouch.net, Dec 12 2017

Issue description

Version: 65.0.3291.0  b667b59a27172510b02c4fce54efb86f1c2689fe-refs/heads/master@{#523021} 32/64 bits
OS : Mac(10.12.6), Windows(7,8,10), Linux(14.04 LTS)

Pre-condition: 
1. Sign-in into browser with valid credential
2. Test URL - https://chrome.google.com/webstore/detail/google-hangouts/knipolnnllmklapflnccelgolnpehhpl?utm_source=chrome-app-launcher-info-dialog

Steps to reproduce the problem?
1. Launch chrome, navigate to above url and install hangout app
3. Observe the hangout window

Actual: Hangout window get blank after launch
Expected: Hangout should work properly

This is an Regression issue broken in M-65, will soon update other info



 
Actual Video.mp4
799 KB View Download
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: lukasza@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Blank window is seen after launching Hangout (was: Regression: Hangout window get blank after lauch)
This is an Regression issue broken in M-65, below is the bisect info:
Good Build:65.3285.0
Bad Build:65.3286.0

You are probably looking for a change made after 521916 (known good), but no later than 521917 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ad9f886718f05495bc3419428c0aa07379acca5c..1c950906dd11eb51e4995e079f87fdbba9eb72cb

Suspect : https://chromium.googlesource.com/chromium/src/+/1c950906dd11eb51e4995e079f87fdbba9eb72cb
Description: Show this description
Labels: ReleaseBlock-Dev
Adding RB Dev Label as this is a recent Regression and is related to Hangouts app. Please remove if not required or else lower the Blocker label.
Thank You.
Cc: rdevlin....@chromium.org
Status: Started (was: Assigned)
Results of ToT (r523441) testing against Hangouts Chrome app (prod and beta), Hangouts Chrome extension (prod):
- Works: ext - prod - nckgahadagoaajjgafhacjanaoiihapd - 2017.1019.418.1
- Broken: app - prod - knipolnnllmklapflnccelgolnpehhpl - 2017.420.419.1
- Broken: app - beta/staging - jfjjdfefebklmdbmenmlehlopoocnoeh - 2017.1019.418.1
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a

commit e4c10ef6c4009f1df94fe36e0585ce59414e0b5a
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Dec 12 23:51:44 2017

Revert "Improve granularity of window namespaces in Blink."

This reverts commit 1c950906dd11eb51e4995e079f87fdbba9eb72cb.

Reason for revert: Broke Hangouts Chrome App - see  https://crbug.com/794079 

Original change's description:
> Improve granularity of window namespaces in Blink.
>
> This CL ensures that blink::FrameTree::Find(const AtomicString& name)
> only looks for a match in the current set of related browsing contexts
> (represented in the browser by content::BrowsingInstance).  This CL
> means that window.open's behavior won't change just because a renderer
> process happens to host multiple unrelated browsing contexts (possible
> for example after reusing a renderer process because of hitting the
> process limit).
>
> This CL consists of 3 parts:
>
> - New browser tests.
>   - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>     for verifying browsing instance boundaries when the
>     renderer processes get reused.
>   - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>     for verifying that extensions can still lookup unrelated frames
>     from the same extension.
>
> - Having blink::Page maintain a set of related pages.
>   - Page::next_related_page_ and Page::prev_related_page_ form a
>     circular, double-linked list of related pages.
>   - Page::CreateOrdinary takes a new |opener| parameter and treats the
>     new page and the |opener| as related and puts them on the same list.
>   - |opener| is propagated from content::RenderViewImpl, through
>     blink::WebViewImpl into blink::Page.
>
> - Falling back to blink embedder when blink::FrameTree::Find finds no frame
>   with the given name.
>   - The fallback is needed to preserve the old behavior for extensions.
>   - The fallback goes through blink::LocalFrameClient,
>     blink::WebFrameClient / content::RenderFrameImpl,
>     content::ContentRendererClient / ::ChromeContentRendererClient,
>     ::ChromeExtensionsRendererClient and finally is implemented
>     by extensions::ExtensionFrameHelper.
>   - Currently the fallback iterates through all same-origin frames in
>     the given process, but requires that the |relative_to_frame| is an
>     extension frame.  In the future we might want to restrict piercing
>     of browsing instances to specific scenarios where it is needed
>     (e.g. restrict it to background pages / contents only?).
>
> I've tested this CL via:
> (all tests below pass before and after the CL, except for
> ProcessReuseVsBrowsingInstance which is fixed by this CL)
>
> - New tests:
>     - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
>       (web -> web shouldn't violate browsing instance)
>     - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
>       (extension/about:blank -> extension can violate browsing instance)
>
> - Existing tests:
>     - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener
>       (chrome.windows.create stays in the same browsing instance depending
>        on the setSelfAsOpener parameter)
>     - AppBackgroundPageApiTest.Basic
>       (hosted app -> background page can violate browsing instance;
>        tests handling of mapping of web urls [full url, not just origin]
>        to extensions)
>
> - Manual testing:
>   - Hangouts Chrome *extension* continues to work (sufficient to
>     validate that sign-in works).  Tested with version 2017.1019.418.1.
>
> Bug:  718489 
> Test: See above.
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Tbr: tommycli@chromium.org
> Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a
> Reviewed-on: https://chromium-review.googlesource.com/764487
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521917}

TBR=dcheng@chromium.org,creis@chromium.org,thestig@chromium.org,wolenetz@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,lukasza@chromium.org,rbpotter@chromium.org


Bug:  718489 ,  794079 
Change-Id: I7ee06ae1b8341044377d5e0ae975888c99d8f700
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/822756
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523609}
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/browser/extensions/extension_functional_browsertest.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/renderer/extensions/chrome_extensions_renderer_client.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/chrome/renderer/extensions/chrome_extensions_renderer_client.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/browser/browsing_instance.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/extensions/renderer/extension_frame_helper.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/extensions/renderer/extension_frame_helper.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/extensions/renderer/scoped_web_frame.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/page/FrameTree.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/e4c10ef6c4009f1df94fe36e0585ce59414e0b5a/third_party/WebKit/public/web/WebView.h

Status: Fixed (was: Started)

Comment 7 by dchau...@etouch.net, Dec 13 2017

Update:-
 Tested this issue on Windows (7,8,10) and Mac OS X(10.12.6,10.13.2) machines using latest Chrome canary build# 65.0.3293.0 fix is working as expected. 

NOTE: Linux build is not yet available, so not adding TE-Verified labels.

Please find the attached screen-cast for reference.

Thanks..!
LatestCanary behavior.mp4
2.5 MB View Download

Comment 8 by xiy...@chromium.org, Dec 13 2017

Cc: xiy...@chromium.org wjmaclean@chromium.org
 Issue 794639  has been merged into this issue.
Labels: TE-Verified-M65 TE-Verified-65.0.3294.0
Update:-
 Tested this issue on Windows (7,8,10), Linux(14.04 LTS) and Mac OS X(10.12.6,10.13.2) machines using latest Chrome canary build# 65.0.3294.0 fix is working as expected.
Expected Video.mp4
1.0 MB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4858e319b8fdedad532443b9e23a02fdd726f8fa

commit 4858e319b8fdedad532443b9e23a02fdd726f8fa
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Jan 17 06:42:39 2018

Don't leak a renderer process when guestview is set as window.opener.

RenderViewHostImpl will be leaked, unless it will be associated
with either a RenderFrameHostImpl or RenderFrameProxyHost (which
maintain RVHI's ref count by calling FrameTree::AddRenderViewHostRef
from their constructors and FrameTree::ReleaseRenderViewHostRef from
their destructors).  Leaking a RenderViewHostImpl leads to leaking
a renderer process.

This CL makes sure that such leak doesn't happen when a guestview is set
as window.opener (in this case a RenderFrameProxyHost exists without an
associated RenderViewHostImpl - we should not create (and leak) a
RenderViewHostImpl in this case).

This CL adds a test that accidentally found the leak of the renderer
process - this test will act as a regression test for the leak.  The
main purpose of the new test though is to act as a regression test
for findability of guestviews that share the same storage partition.

Bug:  802278 ,  794079 
Change-Id: Ibcac8952328b290050f66f4b82d3376b6001c757
Reviewed-on: https://chromium-review.googlesource.com/868631
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529653}
[modify] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/dom_storage_isolation/page.html
[rename] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/dom_storage_isolation/page.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/main.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/manifest.json
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/message.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/message_titles.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/page.html
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/page.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/testing.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/tests.js
[add] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/chrome/test/data/extensions/platform_apps/web_view/findability_isolation/window.html
[modify] https://crrev.com/4858e319b8fdedad532443b9e23a02fdd726f8fa/content/browser/frame_host/render_frame_host_manager.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af2f3357c278d99e9efb4cf3948f6576e47266ec

commit af2f3357c278d99e9efb4cf3948f6576e47266ec
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Jan 17 14:05:08 2018

[reland] Improve granularity of window namespaces in Blink.

This is a reland of r521917 that got reverted in r523609 because of
 https://crbug.com/794079 .

This CL ensures that blink::FrameTree::Find(const AtomicString& name)
only looks for a match in the current set of related browsing contexts
(represented in the browser by content::BrowsingInstance).  This CL
means that window.open's behavior won't change just because a renderer
process happens to host multiple unrelated browsing contexts (possible
for example after reusing a renderer process because of hitting the
process limit).

This CL consists of 3 parts:

- New browser tests.
  - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
    for verifying browsing instance boundaries when the
    renderer processes get reused.
  - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
    for verifying that extensions can still lookup unrelated frames
    from the same extension.

- Having blink::Page maintain a set of related pages.
  - Page::next_related_page_ and Page::prev_related_page_ form a
    circular, double-linked list of related pages.
  - Page::CreateOrdinary takes a new |opener| parameter and treats the
    new page and the |opener| as related and puts them on the same list.
  - |opener| is propagated from content::RenderViewImpl, through
    blink::WebViewImpl into blink::Page.

- Falling back to blink embedder when blink::FrameTree::Find finds no frame
  with the given name.
  - The fallback is needed to preserve the old behavior for extensions
    and guestviews.
  - For extensions the fallback goes through blink::LocalFrameClient,
    blink::WebFrameClient / content::RenderFrameImpl,
    content::ContentRendererClient / ::ChromeContentRendererClient,
    ::ChromeExtensionsRendererClient and finally is implemented
    by extensions::ExtensionFrameHelper.
  - Currently extensions::ExtensionFrameHelper iterates through all
    same-origin frames in the given process, but requires that the
    |relative_to_frame| is an extension frame.  In the future we might
    want to restrict piercing of browsing instances to specific
    scenarios where it is needed (e.g. restrict it to background pages /
    contents only?).
  - Additionally RenderFrameImpl::FindFrame checks all frames within the
    given process if |render_view_->renderer_wide_named_frame_lookup()|
    is set (which is the case for RenderView constructed for guestviews,
    which need to be able to find each other if they are in the same
    storage partision = if they are in the same renderer process).

I've tested this CL via:
(all tests below pass before and after the CL, except for
ProcessReuseVsBrowsingInstance which is fixed by this CL)

- New tests:
    - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
      (web -> web shouldn't violate browsing instance)
    - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
      (extension/about:blank -> extension can violate browsing instance)

- Existing tests:
    - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener
      (chrome.windows.create stays in the same browsing instance depending
       on the setSelfAsOpener parameter)
    - AppBackgroundPageApiTest.Basic
      (hosted app -> background page can violate browsing instance;
       tests handling of mapping of web urls [full url, not just origin]
       to extensions)
    - WebViewTest.FindabilityIsolation
      (guestviews in the same storage partition should be able to find
       each other - regression test for  https://crbug.com/794079 ;
       added in a recent https://crrev.com/c/868631)

- Manual testing:
  - Hangouts Chrome extension
    (nckgahadagoaajjgafhacjanaoiihapd - 2017.1019.418.1).
    - Opens fine (i.e. no impact from r516081)
    - Opens fine in presence of gmail (i.e. b/71647499 is fixed)
  - Hangouts Chrome app
    (knipolnnllmklapflnccelgolnpehhpl - 2017.420.419.1)
    - Opens fine (i.e. no regression of  https://crbug.com/794079 )

Original CL was reviewed on https://crrev.com/c/764487.
The reland (this) CL was reviewed on https://crrev.com/868313.

Bug:  718489 ,  794079 
Test: See above.
Change-Id: I7f6ce7c71a3f995d52797dd187c6c18dee766e4e
Tbr: tommycli@chromium.org
Tbr: Lei Zhang <thestig@chromium.org>
Tbr: Matthew Wolenetz <wolenetz@chromium.org>
Tbr: Rebekah Potter <rbpotter@chromium.org>
Tbr: Charlie Reis <creis@chromium.org>
Tbr: Devlin <rdevlin.cronin@chromium.org>
Tbr: Daniel Cheng <dcheng@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/868313
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529731}
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/browser/chrome_navigation_browsertest.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/browser/extensions/extension_functional_browsertest.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/renderer/extensions/chrome_extensions_renderer_client.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/chrome/renderer/extensions/chrome_extensions_renderer_client.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/browser/browsing_instance.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/common/renderer.mojom
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/renderer/render_frame_impl.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/renderer/render_view_impl.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/content/renderer/render_view_impl.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/extensions/renderer/extension_frame_helper.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/extensions/renderer/extension_frame_helper.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/extensions/renderer/scoped_web_frame.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/frame/FrameTestHelpers.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/page/FrameTree.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/af2f3357c278d99e9efb4cf3948f6576e47266ec/third_party/WebKit/public/web/WebView.h

Sign in to add a comment