New issue
Advanced search Search tips

Issue 794061 link

Starred by 1 user
Status: Archived
Owner:
kinaba@chromium.org
Closed: Dec 2017
Cc:
osh...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ERROR:display_manager_utilities.cc(86)] NOTREACHED() hit.

Project Member Reported by kinaba@chromium.org, Dec 12 2017 
OS: Chrome OS R65-10206.0.0

While I'm debugging other test failures

https://stainless.corp.google.com/search?view=list&first_date=20171208&last_date=20171231&test=GtsMediaTestCases&status=FAIL&reason=retry%5C%28t%3D88%2C+p%3D0%2C+f%3D88%2C+ne%3D0%2C+w%3D2%5C%29&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=true

I noticed an ERROR log

[4575:4575:1211/120907.768849:ERROR:display_manager_utilities.cc(86)] NOTREACHED() hit.

which is from this switch statement:

https://chromium.googlesource.com/chromium/src/+/aba729d699b405e8ac7f47f0df9d780db34b1c13/ui/display/manager/display_manager_utilities.cc#68


The device has 1920x1080 display while the case label says 1980 for FHD... I guess it's a simple typo.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b89bbaa924ae6450dacdd0d5c9c5e174c1fb019

commit 3b89bbaa924ae6450dacdd0d5c9c5e174c1fb019
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Wed Dec 13 01:00:33 2017

Full HD width is 1920.

BUG= 794061 
TEST=no NOTREACHED() from display_manager_utilities.cc on FullHD Chromebooks.

Change-Id: I473526931a9b1bba69c7885a4da0897d8ccd4898
Reviewed-on: https://chromium-review.googlesource.com/821791
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523636}
[modify] https://crrev.com/3b89bbaa924ae6450dacdd0d5c9c5e174c1fb019/ui/display/manager/display_manager_utilities.cc

Comment 2 by kinaba@chromium.org, Dec 13 2017

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment