New issue
Advanced search Search tips

Issue 794051 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

The first touch of password field should trigger autofill suggestion

Project Member Reported by michaelbai@chromium.org, Dec 12 2017

Issue description

Currently, the password autofill query is skipped in AutofillAgent because it is supposed be handled by PasswordAutofillAgent.

We should have an option to let AutofillAgent send the query to WebView.
 
see, http://b/70529048
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2

commit a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2
Author: Tao Bai <michaelbai@chromium.org>
Date: Mon Dec 18 19:47:36 2017

[WebView autofill] add the option to query password suggestion

By default AutofillAgent doesn't query password suggestion because
it is handled by PasswordAgent.

This patch adds an option to query password suggestion for WebView.

Bug:  794051 
Change-Id: Ia3552bbb3af7f9c9f15e2cc044b272393705f198
Reviewed-on: https://chromium-review.googlesource.com/822161
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524768}
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/components/autofill/content/browser/content_autofill_driver_unittest.cc
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/components/autofill/content/common/autofill_agent.mojom
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/a8c0d8bba8bfbaaffe2794e8c4c6f82fc0df33a2/components/autofill/content/renderer/autofill_agent.h

Status: Fixed (was: Assigned)

Sign in to add a comment