Bumping up the priority since we'll want to merge into M-64 if possible.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbe084be13c98a8048d1facee55ac59c66df279

commit 8fbe084be13c98a8048d1facee55ac59c66df279
Author: Mehran Mahmoudi <mahmoudi@chromium.org>
Date: Tue Dec 12 01:50:41 2017

[TTS] Replace BarBanner with TextBubble for IPH for CS

Per UI Review's comment, this CL removes the use of BarBanner for an
In-Product Help for Contextual Search scenario, and replaces it with the more
familiar TextBubble.
Discussion: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/2_I2G2yqLUI/s2AnV5WABwAJ

Bug:  794013 
Change-Id: I3b76aadac1dbe5981fb5b3d5fca989ca11157a21
Reviewed-on: https://chromium-review.googlesource.com/821411
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523299}
[modify] https://crrev.com/8fbe084be13c98a8048d1facee55ac59c66df279/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
[modify] https://crrev.com/8fbe084be13c98a8048d1facee55ac59c66df279/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchIPH.java
[modify] https://crrev.com/8fbe084be13c98a8048d1facee55ac59c66df279/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
[modify] https://crrev.com/8fbe084be13c98a8048d1facee55ac59c66df279/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

I would like to merge this CL to 64 if possible. It addresses a comment made by the UI Review team, for changing a UI element.
Main feature's launch bug: crbug.com/782227
Design doc: go/iph-for-cs
UI Review discussion: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/2_I2G2yqLUI/s2AnV5WABwAJ

Thank you.

Merge approved since the feature can be disabled from Finch experiments as per the test survey on crbug.com/782227.

One thing though. Can you add some tests along with that cl?

Thanks for the prompt approval.
This UI element (TextBubble) is used in a number of other components as In-Product Help, including Chrome Home, Downloads, Data Saver, etc. Therefore, we don't think adding new tests is necessary for this CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa1f18119b7e26135e101af02fb50dfd1bf155f

commit 1fa1f18119b7e26135e101af02fb50dfd1bf155f
Author: Mehran Mahmoudi <mahmoudi@chromium.org>
Date: Tue Dec 12 21:35:08 2017

[TTS] Replace BarBanner with TextBubble for IPH for CS

Per UI Review's comment, this CL removes the use of BarBanner for an
In-Product Help for Contextual Search scenario, and replaces it with the more
familiar TextBubble.
Discussion: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/2_I2G2yqLUI/s2AnV5WABwAJ

Bug:  794013 
Change-Id: I3b76aadac1dbe5981fb5b3d5fca989ca11157a21
Reviewed-on: https://chromium-review.googlesource.com/821411
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523299}(cherry picked from commit 8fbe084be13c98a8048d1facee55ac59c66df279)
Reviewed-on: https://chromium-review.googlesource.com/822921
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#182}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/1fa1f18119b7e26135e101af02fb50dfd1bf155f/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
[modify] https://crrev.com/1fa1f18119b7e26135e101af02fb50dfd1bf155f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchIPH.java
[modify] https://crrev.com/1fa1f18119b7e26135e101af02fb50dfd1bf155f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
[modify] https://crrev.com/1fa1f18119b7e26135e101af02fb50dfd1bf155f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Just for posterity, would I be able to see a quick screenshot of the update? Thanks!

I've updated the design doc and the UI implementation slides to include the new design.

https://docs.google.com/document/d/1LgQLYDFxRnilKVT2khQSGaf5jcjD6nR7STZJjqzNr9c/edit#heading=h.23ea6fz9ov39

Thanks for the quick response! Is there a way to make the bubble slightly overlap the bottom panel so that it feels more like trusted UI that can't easily be faked / won't accidentally point to content on the site?

Deleted: Screen Shot 2017-12-13 at 14.59.01.png 26.6 KB

	Screen Shot 2017-12-13 at 14.59.01.png 26.6 KB View Download

Sure. The bubble had a 10dp padding from the bottom. I've changed it to -5dp. If it looks alright to you, I'll submit it.

Screenshot: https://drive.google.com/file/d/1LZ764yqCgZ-4pMYk8luL8p0saJ4abFV_/view?usp=sharing

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37950cec27f8c24a24aef28be21db5ec37e9e0d6

commit 37950cec27f8c24a24aef28be21db5ec37e9e0d6
Author: Mehran Mahmoudi <mahmoudi@chromium.org>
Date: Fri Dec 15 19:39:50 2017

[TTS] Fix bottom padding for IPH bubble

This CL decreases the bottom padding of the In-Product Help bubbles for
Contextual Search, to overlap the panel, as per UI Review's comment.

Bug:  794013 
Change-Id: I607f5ea31f3cea0cbd370b9a3b19fddd6b8db385
Reviewed-on: https://chromium-review.googlesource.com/829879
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524437}
[modify] https://crrev.com/37950cec27f8c24a24aef28be21db5ec37e9e0d6/chrome/android/java/res/values/dimens.xml