Issue metadata
Sign in to add a comment
|
Unable to set camera captured photo as profile pic |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 64.0.3282.22 (Official Build) dev (64-bit) Revision 0 Platform 10176.11.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Create a new user account from Sign-in screen 2. On picture selection screen, select camera. 3. Take picture. 4. Click on OK to login 5. Check user avatar in uber panel. What is the expected result? Camera captured image should be displayed in uber panel. What happens instead? Some default profile pic is seen. Issue repro'd on M63 as well. Not repro'd on M62 stable.
,
Dec 22 2017
,
Jan 4 2018
sdantuluri@, please add M63 label if this is an issue in M63 as well.
,
Jan 4 2018
https://chromium-review.googlesource.com/#/c/chromium/src/+/850073 will fix the issue but I'm not sure it's correct.
,
Jan 4 2018
Issue reproducible on latest M63 10032.79.0, 63.0.3239.132
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e528a87c65b674150ee59c6520dd39fac2a759d0 commit e528a87c65b674150ee59c6520dd39fac2a759d0 Author: David Reveman <reveman@chromium.org> Date: Fri Jan 05 04:25:47 2018 Change Picture: Select image after taking photo on OOBE screen. This is needed for for photo to be accepted as user image when OK button is clicked. Without it the user has to explicitly click on the photo element in the picture list. Bug: 794002 Test: Take photo and press OK on OOBE screen. Photo becomes user image. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibcc2b52ac5f2b7983889c70a1158448f00b66268 Reviewed-on: https://chromium-review.googlesource.com/850073 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#527196} [modify] https://crrev.com/e528a87c65b674150ee59c6520dd39fac2a759d0/chrome/browser/resources/chromeos/login/oobe_change_picture.js
,
Jan 5 2018
,
Jan 5 2018
Did the doubts in #4 get addressed?
,
Jan 5 2018
#8, yes, we all agree that this is the appropriate fix. Fyi, the concern was not if it would fix the issue or not but whether there's was a better way to fix it.
,
Jan 5 2018
,
Jan 5 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1292d39a214fb57aac9cae403196f3f9a99b4547 commit 1292d39a214fb57aac9cae403196f3f9a99b4547 Author: David Reveman <reveman@chromium.org> Date: Fri Jan 05 20:17:39 2018 Change Picture: Select image after taking photo on OOBE screen. This is needed for for photo to be accepted as user image when OK button is clicked. Without it the user has to explicitly click on the photo element in the picture list. TBR=reveman@chromium.org (cherry picked from commit e528a87c65b674150ee59c6520dd39fac2a759d0) Bug: 794002 Test: Take photo and press OK on OOBE screen. Photo becomes user image. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibcc2b52ac5f2b7983889c70a1158448f00b66268 Reviewed-on: https://chromium-review.googlesource.com/850073 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#527196} Reviewed-on: https://chromium-review.googlesource.com/852376 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#712} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/1292d39a214fb57aac9cae403196f3f9a99b4547/chrome/browser/resources/chromeos/login/oobe_change_picture.js
,
Jan 6 2018
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 8 2018
Approving merge to M64 Chrome OS.
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10b05dca657baebd1c57914c147b4a5c65ab260a commit 10b05dca657baebd1c57914c147b4a5c65ab260a Author: David Reveman <reveman@chromium.org> Date: Mon Jan 08 18:12:02 2018 Change Picture: Select image after taking photo on OOBE screen. This is needed for for photo to be accepted as user image when OK button is clicked. Without it the user has to explicitly click on the photo element in the picture list. TBR=reveman@chromium.org (cherry picked from commit e528a87c65b674150ee59c6520dd39fac2a759d0) (cherry picked from commit 1292d39a214fb57aac9cae403196f3f9a99b4547) Bug: 794002 Test: Take photo and press OK on OOBE screen. Photo becomes user image. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibcc2b52ac5f2b7983889c70a1158448f00b66268 Reviewed-on: https://chromium-review.googlesource.com/850073 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#527196} Reviewed-on: https://chromium-review.googlesource.com/852376 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3239@{#712} Cr-Original-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} Reviewed-on: https://chromium-review.googlesource.com/854553 Cr-Commit-Position: refs/branch-heads/3282@{#446} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/10b05dca657baebd1c57914c147b4a5c65ab260a/chrome/browser/resources/chromeos/login/oobe_change_picture.js
,
Jan 10 2018
Verified on M63 10032.86.0, 63.0.3239.140 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdantul...@chromium.org
, Dec 22 2017