New issue
Advanced search Search tips

Issue 793995 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Mobile] Improve telemetry logging

Project Member Reported by yuweih@chromium.org, Dec 12 2017 
During the iOS app dogfood period, we see some raise and drop in the telemetry metrics but we still lack some data to explain them. Here are the issues:

* The third party auth failure is not reported, which accounts for a significant part of failure reasons during dogfood period.
* No close event will be logged if the app is killed and the user never manually disconnects. This might be impossible to fix due to API limitation.
* When logging session state changes, we never log the previous session state. This makes it hard to analyze success rate and error breakdown in each stage.
* (P3) SessionEntryPoint is never logged.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5c3cc45f9ee2dc3051dd41b94e98228f1d8d4e

commit 9c5c3cc45f9ee2dc3051dd41b94e98228f1d8d4e
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Jan 18 20:10:12 2018

[Remoting Mobile] Rewire connection state reporting logic for telemetry

This CL improves the connection state report accuracy such that:
* If session is disconnected before the CONNECTED state, report a
  CANCEL event. Previously nothing is reported in this state.
* If session is disconnected during the CONNECTED state, report a CLOSE
  event.
* On iOS, report an AUTHENTICATION_FAILED error if the user tries to do
  a third party auth, which is not supported. Previously we don't
  report anything and when this happens.

Bug:  793995 
Change-Id: I9155c0efe43892149179e70f52ecee17434ff88e
Reviewed-on: https://chromium-review.googlesource.com/869457
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530249}
[modify] https://crrev.com/9c5c3cc45f9ee2dc3051dd41b94e98228f1d8d4e/remoting/client/chromoting_session.cc
[modify] https://crrev.com/9c5c3cc45f9ee2dc3051dd41b94e98228f1d8d4e/remoting/client/chromoting_session.h
[modify] https://crrev.com/9c5c3cc45f9ee2dc3051dd41b94e98228f1d8d4e/remoting/ios/session/remoting_client.mm

Comment 2 by yuweih@chromium.org, Mar 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment