Android symbolize script had stack traces off by a few lines |
|||
Issue descriptionIn this patchset https://chromium-review.googlesource.com/c/chromium/src/+/820453/1 (note you'll have to sync before this change is committed to repro) with these GN flags use_goma = true target_os = "android" target_cpu = "arm64" is_component_build = true system_webview_package_name = "com.google.android.webview" I would build and run this test: ninja -C out/Debug content_browsertests -j 1000 adb logcat -c out/Debug/bin/run_content_browsertests --gtest-filter DevToolsProtocolTest.ReloadBlankPage adb logcat -d > /tmp/cbtcrash third_party/android_platform/development/scripts/stack --arch=arm64 --output-directory=out/Debug /tmp/cbtcrash > /tmp/cbt However the stack trace was always off. It would always point to this statement web_contents_->GetInterstitialPage()->Focus(); in web_contents_view_android.cc while it was really two lines below, i.e. "rwhv->Focus()". I know it was the latest build, because as I added logging I would see it. John: not sure who to assign this to, so please triage. Thanks.
,
Dec 12 2017
-> hzl, who has been working on Android symbolization lately
,
Dec 12 2017
Locally I am also trying to reproduce the issue. I tried the following steps: 1) gclient to latest 2) revert the patch that fixes the crash mentioned in @jam's comment, so that I can see the crash 3) set gn flags, build, run using the command specified by @jam I see this issue "INSTALL_FAILED_NO_MATCHING_ABIS: Failed to extract native libraries". I am running it on a Nexus 6 device. Any idea how to work around it?
,
Dec 12 2017
n6 is 32bit only, maybe you want target_cpu = "arm" instead
,
Dec 12 2017
I'm using a pixel 2 which is 64 bit (in case that could affect the bug)
,
Dec 13 2017
Thanks Bo for the tip. I changed target_cpu to "arm" and the test can be run. However it seems to pass on nexus 6. I reverted this change locally: https://chromium-review.googlesource.com/c/chromium/src/+/820453/1/content/browser/frame_host/navigator_impl.cc But it doesn't seem to fail on nexus 6.
,
Dec 13 2017
Let me try it on a 64 bit device.
,
Dec 13 2017
You need to sync to 523263 and then apply that patch.
,
Dec 13 2017
Sync to 523263 and then git cl patch 820453? Let me try it.
,
Dec 13 2017
hmm It still doesn't crash. I have a pixel 2. I tried syncing to 523263 only and also tried syncing to 523263 and then git cl patch 820453. Both seem to pass and not fail.
,
Dec 15 2017
You need to manually apply the patch from the first upload, i.e. https://chromium-review.googlesource.com/c/chromium/src/+/820453/1 if you just do git cl patch 820453, it will apply the crash fix as well and you won't be able to repro
,
Aug 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Dec 11 2017