New issue
Advanced search Search tips

Issue 793975 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-XR

Blocking:
issue 715118
issue 793387



Sign in to add a comment

Assets Component: Enable immediate download when entering VR

Project Member Reported by tiborg@chromium.org, Dec 11 2017

Issue description

Immediately start component download when entering VR if component is not already installed.

See the downloadable strings component for how that could be done (https://cs.chromium.org/chromium/src/chrome/browser/component_updater/downloadable_strings_component_installer.cc?rcl=561193ab845c0eb9457ce7104b3b2f41565269d7&l=448).
 

Comment 1 by tiborg@chromium.org, Dec 11 2017

Blocking: 793377

Comment 2 by tiborg@chromium.org, Dec 14 2017

Blocking: -793377 793387
If we want to block the user from entering VR Browsing Mode we have to have the ability to immediately download the component.

Comment 3 by tiborg@chromium.org, Dec 15 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2c2f916eb0391802d9f4d37be2651d67956f85

commit 8a2c2f916eb0391802d9f4d37be2651d67956f85
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Jan 05 19:06:54 2018

[vr] Update assets component when entering VR and component not ready

We need the assets component in VR browsing mode to provide the best
user experience. Thus, initiate an immediate update check when entering
VR and no compatible component is available in order to minimize the
time the user has to browse in the fallback browsing mode.

Bug:  793975 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7a74173807e76a457c0f8c7bfed7384596c90e35
Reviewed-on: https://chromium-review.googlesource.com/850852
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527338}
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/chrome/browser/BUILD.gn
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/chrome/browser/component_updater/vr_assets_component_installer.h
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/chrome/browser/vr/features.gni
[modify] https://crrev.com/8a2c2f916eb0391802d9f4d37be2651d67956f85/components/component_updater/component_updater_service.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6

commit 75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6
Author: Tommy Martino <tmartino@chromium.org>
Date: Fri Jan 05 19:30:27 2018

Revert "[vr] Update assets component when entering VR and component not ready"

This reverts commit 8a2c2f916eb0391802d9f4d37be2651d67956f85.

Reason for revert: This seems to be breaking the Windows build.
Example of failed build: 
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/25585

Original change's description:
> [vr] Update assets component when entering VR and component not ready
> 
> We need the assets component in VR browsing mode to provide the best
> user experience. Thus, initiate an immediate update check when entering
> VR and no compatible component is available in order to minimize the
> time the user has to browse in the fallback browsing mode.
> 
> Bug:  793975 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I7a74173807e76a457c0f8c7bfed7384596c90e35
> Reviewed-on: https://chromium-review.googlesource.com/850852
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527338}

TBR=vollick@chromium.org,waffles@chromium.org,tiborg@chromium.org

Change-Id: I826b17d03bca4157fc29fae0f05125002708c406
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  793975 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/852895
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527343}
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/chrome/browser/BUILD.gn
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/chrome/browser/component_updater/vr_assets_component_installer.h
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/chrome/browser/vr/features.gni
[modify] https://crrev.com/75e3ffd07f6692e7d77e358f1bd0f107f57d2eb6/components/component_updater/component_updater_service.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0139208fb905d492b92f77800a9282d071a030b

commit f0139208fb905d492b92f77800a9282d071a030b
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Jan 05 23:21:07 2018

Reland "[vr] Update assets component when entering VR and component not ready"

This is a reland of 8a2c2f916eb0391802d9f4d37be2651d67956f85
Original change's description:
> [vr] Update assets component when entering VR and component not ready
>
> We need the assets component in VR browsing mode to provide the best
> user experience. Thus, initiate an immediate update check when entering
> VR and no compatible component is available in order to minimize the
> time the user has to browse in the fallback browsing mode.
>
> Bug:  793975 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I7a74173807e76a457c0f8c7bfed7384596c90e35
> Reviewed-on: https://chromium-review.googlesource.com/850852
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527338}

TBR=vollick@chromium.org,waffles@chromium.org

Bug:  793975 
Change-Id: Idf04fe94ae635655bf300b874b779842b1419eac
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/852952
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527426}
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/chrome/browser/BUILD.gn
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/chrome/browser/component_updater/vr_assets_component_installer.h
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/chrome/browser/vr/features.gni
[modify] https://crrev.com/f0139208fb905d492b92f77800a9282d071a030b/components/component_updater/component_updater_service.h

Status: Fixed (was: Started)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment