New issue
Advanced search Search tips

Issue 793971 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Separate Android GPU.FYI bots into builders and testers

Project Member Reported by ynovikov@chromium.org, Dec 11 2017

Issue description

All Android GPU.FYI bots are builder_tester type.
We should be able to avoid building the same code multiple times by having the builders separate from the testers, as the rest of platforms do.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ab6e099d6476b172f47b0a816d89eff1116aeb12

commit ab6e099d6476b172f47b0a816d89eff1116aeb12
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Dec 15 23:50:23 2017

Add Android builders to GPU.FYI

Going to split builder_tester bots into builders and testers.
This is a first step - adding builders to see how they work.
Will turn builder_testers into testers in the next step.

BUG= chromium:793971 

Change-Id: I0e22f01f3b6a756ff05d96ab0de537c9398d861d
Reviewed-on: https://chromium-review.googlesource.com/821251
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/ab6e099d6476b172f47b0a816d89eff1116aeb12/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/ab6e099d6476b172f47b0a816d89eff1116aeb12/masters/master.chromium.gpu.fyi/builders.pyl

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/5b2736075395fb941a0d90f4c20725f3bac72692

commit 5b2736075395fb941a0d90f4c20725f3bac72692
Author: Kenneth Russell <kbr@google.com>
Date: Sat Dec 16 03:23:06 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a642d120f7dbd96ba00807fce6cbcc63232a030f

commit a642d120f7dbd96ba00807fce6cbcc63232a030f
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Dec 21 02:24:42 2017

Revert "Add Android builders to GPU.FYI"

This reverts commit ab6e099d6476b172f47b0a816d89eff1116aeb12.

Reason for revert: temporarily disabling because "package build" step
uses up too much storage.

Original change's description:
> Add Android builders to GPU.FYI
> 
> Going to split builder_tester bots into builders and testers.
> This is a first step - adding builders to see how they work.
> Will turn builder_testers into testers in the next step.
> 
> BUG= chromium:793971 
> 
> Change-Id: I0e22f01f3b6a756ff05d96ab0de537c9398d861d
> Reviewed-on: https://chromium-review.googlesource.com/821251
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

TBR=ynovikov@chromium.org,kbr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:793971 , chromium:796667
Change-Id: Ib5ef6ebd6109e1d62290b32a9f5712ef8bebbef1
Reviewed-on: https://chromium-review.googlesource.com/838680
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/a642d120f7dbd96ba00807fce6cbcc63232a030f/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/a642d120f7dbd96ba00807fce6cbcc63232a030f/masters/master.chromium.gpu.fyi/builders.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2acec2645b3e8f87f0c51a4fb11e97521b67333e

commit 2acec2645b3e8f87f0c51a4fb11e97521b67333e
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Dec 21 04:08:28 2017

Revert "Add Android builders to GPU.FYI"

This reverts commit 999fa2ecde31bcb0017211600a05cf35bdb7c9be.

Reason for revert: temporarily disabling because "package build" step
uses up too much storage.

Original change's description:
> Add Android builders to GPU.FYI
>
> BUG=793970
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I44b9c33f7d7dc2bfde4e0cf4093e91dd80adc391
> Reviewed-on: https://chromium-review.googlesource.com/821470
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524526}

TBR=ynovikov@chromium.org,dpranke@chromium.org,kbr@chromium.org
NOTRY=true

Bug:  793971 , 796667
Change-Id: I80cc1e0d91f134a86a2f0ee68a78fc377b65e019
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/838660
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525595}
[modify] https://crrev.com/2acec2645b3e8f87f0c51a4fb11e97521b67333e/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/2acec2645b3e8f87f0c51a4fb11e97521b67333e/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/2acec2645b3e8f87f0c51a4fb11e97521b67333e/tools/mb/mb_config.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/dff76851349ffb6db3aed2a04d5179fd361369de

commit dff76851349ffb6db3aed2a04d5179fd361369de
Author: Kenneth Russell <kbr@google.com>
Date: Thu Dec 21 04:35:46 2017

Blockedon: 754104
Status: Assigned (was: Started)
Blockedon: -754104
Status: WontFix (was: Assigned)
Seems like we have different build flags for many of our Android bots, so this change will not benefit us much. Also, looks like the general direction for new bots is to be builder/tester.

Sign in to add a comment