New issue
Advanced search Search tips

Issue 793968 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
STS
Team-Accessibility



Sign in to add a comment

[Select-to-Speak on ARC++] node highlighting turns on and off

Project Member Reported by katie@chromium.org, Dec 11 2017

Issue description

Looks like the node often thinks it is not in the foreground in onHitTestCheckCurrentNodeMatches_, so the focus ring gets removed almost as soon as it is set.

[Splitting off from another bug which had 2 issues in 1]
 

Comment 1 by katie@chromium.org, Dec 11 2017

Labels: STS

Comment 2 by katie@chromium.org, Jan 8 2018

Owner: katie@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390ff9702c40b2a62851df467281ac31db3e5073

commit 390ff9702c40b2a62851df467281ac31db3e5073
Author: Katie Dektar <katydek@google.com>
Date: Tue Jan 09 03:03:02 2018

Fix select-to-speak focus ring drawing in ARC++.

Previously the focus ring would quickly be removed because hit testing
returned the wrong window. Now, look for the current focused node
and use that if windows don't match.

The same ARC++ hittest workaround is already in line 444 in Select-to-Speak.

Bug:  793968 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic9371e9716613a8f06db10fc280e77b0997e7660
Reviewed-on: https://chromium-review.googlesource.com/854944
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527883}
[modify] https://crrev.com/390ff9702c40b2a62851df467281ac31db3e5073/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js

Comment 4 by katie@chromium.org, Jan 9 2018

Status: Fixed (was: Started)

Comment 5 by katie@chromium.org, Jan 10 2018

Labels: a11y-testing
Components: UI>Accessibility>SelectToSpeak
Moving from just having STS label to also having the UI>Accessibility>SelectToSpeak component to make searching easier in the future. 
Labels: a11y-testers
Labels: -a11y-testing -a11y-testers
Status: Verified (was: Fixed)
Google Chrome	68.0.3440.15 (Official Build) dev (64-bit)
Firmware Version Google_Lulu.6301.136.57

Tested in non-corp account using Google Play Music app
Steps:
Use STS to highlight several times, checking for flickering or turning off and on

Behaved as expected with continuous highlight 


Sign in to add a comment