New issue
Advanced search Search tips

Issue 793956 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

[Fuchsia] Ninja ignores changes in SDK headers

Project Member Reported by sergeyu@chromium.org, Dec 11 2017 
1. Build a binary for Fuchsia
2. Update a system headers in Fuchsia (e.g. change O_* flags values in fcntl.h)
3. Build new SDK using tools/fuchsia/local-sdk.py
4. Run ninja - it wan't rebuld files that depend on updated files

Comment 1 by scottmg@chromium.org, Dec 11 2017 

Rebuild works on "real" sdk updates, but not with local-sdk.py due to https://cs.chromium.org/chromium/src/tools/fuchsia/local-sdk.py?rcl=9ae5e682de79abafd24549e3aed76ce523562629&l=67 .

For reasons unknown to me (I guess faster builds?) the gcc/clang family build files use -MMD not -MD for dependency so they don't include deps on system headers.

Comment 2 by sergeyu@chromium.org, Dec 11 2017

Owner: sergeyu@chromium.org
Status: Ass (was: Untriaged)

Comment 3 by sergeyu@chromium.org, Dec 11 2017

Status: assigned (was: ass)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/271acc6608e2fc96d3ccf9c73e9f95423d7801db

commit 271acc6608e2fc96d3ccf9c73e9f95423d7801db
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Dec 11 23:16:59 2017

fuchsia: Hash sysroot in local-sdk.py

Bug:  793956 
Change-Id: I8c1fe8a4e77b754a03e0d257f944c0ce5037fb72
Reviewed-on: https://chromium-review.googlesource.com/820853
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523243}
[modify] https://crrev.com/271acc6608e2fc96d3ccf9c73e9f95423d7801db/tools/fuchsia/local-sdk.py

Comment 5 by scottmg@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment