Later image previews take an age to load when lots of images in gallery |
||||
Issue descriptionChrome Version: 65.0.3288.3 OS: Android 8.1 (Pixel 2 XL) What steps will reproduce the problem? (0) Note: You need a lot of photos (say, 1000) (1) Find any site that supports input type=file accept image (2) Try to pick a file, so that you get the nice new image picker (3) Scroll to an image further down the list (I like photos from a couple of weeks ago) (4) You will have to wait for all the other preview images to preview render before you can see the image you want. What is the expected result? I would expect the preview images to be lazily loaded based on the rough offset of the image that would be in the viewport so that I can quickly see the image I need to choose. What happens instead? For a preview of image 1000, it renders a preview of all the images 0-999 first. It took about a minute to get to the images that should have been previewed in the screenshot and made it nearly impossible to use.
,
Dec 11 2017
,
Dec 12 2017
Hmm, there's code in there already to handle this case. Looks like that must be broken. I'll take a look.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e714cdc4eebe63de4d802af85b099cd4126a187f commit e714cdc4eebe63de4d802af85b099cd4126a187f Author: Finnur Thorarinsson <finnur@chromium.org> Date: Thu Dec 14 17:17:11 2017 Android Photo Picker: Cancel outdated requests again. Somewhere along the way we stopped listening to recycler events, which breaks the mechanism that invalidates old (outdated) requests for decoding. This CL reinstates that. Bug: 793934 , 656015 Change-Id: I0df070c851bb75a1dccd1e7b5854c8846905ceb9 Reviewed-on: https://chromium-review.googlesource.com/827015 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524095} [modify] https://crrev.com/e714cdc4eebe63de4d802af85b099cd4126a187f/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
,
Dec 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by paulkinlan@chromium.org
, Dec 11 2017