New issue
Advanced search Search tips

Issue 793924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

aura::Env::context_factory_private is not set up correctly in ash_unitests-mus

Project Member Reported by penghuang@chromium.org, Dec 11 2017

Issue description

Comment 1 by sky@chromium.org, Dec 11 2017

Here's the code that sets the context_factory for ash_unittests: https://chromium.googlesource.com/chromium/src/+/master/ash/test/ash_test_suite.cc#76 .

Comment 2 by sadrul@chromium.org, Dec 11 2017

Cc: -penghuang@chromium.org sadrul@chromium.org
Owner: penghuang@chromium.org
You probably need something like https://paste.googleplex.com/4856276748075008
With https://paste.googleplex.com/4856276748075008, crash stacks changed to:

[       OK ] HighlighterControllerTest.HighlighterGesturesRotated (309 ms)
[----------] 1 test from HighlighterControllerTest (309 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (309 ms total)
[  PASSED  ] 1 test.
[105779:105779:1211/161313.359829:3657262718145:FATAL:sync_point_manager.cc(325)] Check failed: order_data_map_.empty(). 
#0 0x7f517b1965cc base::debug::StackTrace::StackTrace()
#1 0x7f517b1bd03c logging::LogMessage::~LogMessage()
#2 0x7f5179002d4f gpu::SyncPointManager::~SyncPointManager()
#3 0x7f5179032d86 gpu::(anonymous namespace)::GpuInProcessThreadHolder::~GpuInProcessThreadHolder()
#4 0x7f5179032d22 base::LazyInstance<>::OnExit()
#5 0x7f517b181054 base::AtExitManager::ProcessCallbacksNow()
#6 0x7f517b180e28 base::AtExitManager::~AtExitManager()
#7 0x000000a9535b base::TestSuite::~TestSuite()
#8 0x00000084f596 main
#9 0x7f517773d2b1 __libc_start_main
#10 0x00000051092a _start

Received signal 6
#0 0x7f517b1965cc base::debug::StackTrace::StackTrace()
#1 0x7f517b1960c1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f517b8e50c0 <unknown>
#3 0x7f517774ffcf gsignal
#4 0x7f51777513fa abort
#5 0x7f517b193a85 base::debug::BreakDebugger()
#6 0x7f517b1bd3de logging::LogMessage::~LogMessage()
#7 0x7f5179002d4f gpu::SyncPointManager::~SyncPointManager()
#8 0x7f5179032d86 gpu::(anonymous namespace)::GpuInProcessThreadHolder::~GpuInProcessThreadHolder()
#9 0x7f5179032d22 base::LazyInstance<>::OnExit()
#10 0x7f517b181054 base::AtExitManager::ProcessCallbacksNow()
#11 0x7f517b180e28 base::AtExitManager::~AtExitManager()
#12 0x000000a9535b base::TestSuite::~TestSuite()
#13 0x00000084f596 main
#14 0x7f517773d2b1 __libc_start_main
#15 0x00000051092a _start
  r8: 0000000000000000  r9: 00007ffccd31db80 r10: 0000000000000008 r11: 0000000000000246
 r12: 00007ffccd31e288 r13: 00007ffccd31e278 r14: 00007ffccd31e280 r15: 00007ffccd31ddd0
  di: 0000000000000002  si: 00007ffccd31db80  bp: 00007ffccd31ddc0  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007f517774ffcf  sp: 00007ffccd31dbf8
  ip: 00007f517774ffcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

Comment 4 by sadrul@chromium.org, Dec 11 2017

Call ui::TerminateContextFactoryForTests() in AshTestHelper::TearDown() unconditionally.
It fixes this issue. Thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe678147420c0ea622dcdebd4d86e7b6162d5c40

commit fe678147420c0ea622dcdebd4d86e7b6162d5c40
Author: Peng Huang <penghuang@chromium.org>
Date: Wed Dec 13 01:35:24 2017

Fix exo for IsMusHostingVis() == false

Bug:  792479 ,  793924 
Test: Test on device with android apps
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952
Reviewed-on: https://chromium-review.googlesource.com/806689
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523647}
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ash/test/ash_test_helper.cc
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ash/test/ash_test_suite.cc
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/DEPS
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/aura/mus/window_port_mus_unittest.cc
[modify] https://crrev.com/fe678147420c0ea622dcdebd4d86e7b6162d5c40/ui/compositor/test/in_process_context_factory.cc

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e763ffcb4b98659e76d280a86c7c61072f090fcc

commit e763ffcb4b98659e76d280a86c7c61072f090fcc
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Dec 13 13:59:35 2017

Revert "Fix exo for IsMusHostingVis() == false"

This reverts commit fe678147420c0ea622dcdebd4d86e7b6162d5c40.

Reason for revert: Breaks several tests in ash_unittests-mus on Builder Linux Chromium OS ASan LSan Tests
See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187

Original change's description:
> Fix exo for IsMusHostingVis() == false
> 
> Bug:  792479 ,  793924 
> Test: Test on device with android apps
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952
> Reviewed-on: https://chromium-review.googlesource.com/806689
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523647}

TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org

Change-Id: If258d1188a54f4406b6f0edf0c37ead6c89379b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  792479 ,  793924 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/823925
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523764}
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ash/test/ash_test_helper.cc
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ash/test/ash_test_suite.cc
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/DEPS
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/aura/mus/window_port_mus_unittest.cc
[modify] https://crrev.com/e763ffcb4b98659e76d280a86c7c61072f090fcc/ui/compositor/test/in_process_context_factory.cc

Comment 9 by samans@chromium.org, Dec 13 2017

Status: Assigned (was: Fixed)
Re-opening because the patch got reverted
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6a3c6be2bd853352d4cf9aaa85307b1df88528

commit ec6a3c6be2bd853352d4cf9aaa85307b1df88528
Author: Peng Huang <penghuang@chromium.org>
Date: Wed Dec 13 18:34:10 2017

Revert "Revert "Fix exo for IsMusHostingVis() == false""

This reverts commit e763ffcb4b98659e76d280a86c7c61072f090fcc.

Reason for revert: The problem for reverting https://crrev.com/c/806689
has been fixed by https://crrev.com/c/824434.

Original change's description:
> Revert "Fix exo for IsMusHostingVis() == false"
> 
> This reverts commit fe678147420c0ea622dcdebd4d86e7b6162d5c40.
> 
> Reason for revert: Breaks several tests in ash_unittests-mus on Builder Linux Chromium OS ASan LSan Tests
> See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187
> 
> Original change's description:
> > Fix exo for IsMusHostingVis() == false
> > 
> > Bug:  792479 ,  793924 
> > Test: Test on device with android apps
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> > Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952
> > Reviewed-on: https://chromium-review.googlesource.com/806689
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#523647}
> 
> TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org
> 
> Change-Id: If258d1188a54f4406b6f0edf0c37ead6c89379b4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  792479 ,  793924 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/823925
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523764}

TBR=penghuang@chromium.org,sadrul@chromium.org,sky@chromium.org,piman@chromium.org,cfroussios@chromium.org

Change-Id: I5ec6e8befda01fbbd320ee048aab998623e2b830
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  792479 ,  793924 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/825282
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523830}
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ash/test/ash_test_helper.cc
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ash/test/ash_test_suite.cc
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/local/layer_tree_frame_sink_local.h
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/DEPS
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/aura/mus/window_port_mus_unittest.cc
[modify] https://crrev.com/ec6a3c6be2bd853352d4cf9aaa85307b1df88528/ui/compositor/test/in_process_context_factory.cc

Status: Fixed (was: Assigned)
CL has been relanded. Close this issue.
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment