New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

White-label clean-up patch

Project Member Reported by sjg@chromium.org, Dec 11 2017

Issue description

There is one CL for unibuild whitelabel support that we would like to cherry-pick to M64.

https://chromium-review.googlesource.com/c/chromiumos/platform/firmware/+/791534

This is a clean-up to make the firmware updater the same as ToT.

 
Can you please mark which OS's this impacts? And why is this needed for M64, vs waiting for M65?

Comment 2 by sjg@chromium.org, Dec 11 2017

Labels: -Pri-3 OS-Linux Pri-2

Comment 3 by sjg@chromium.org, Dec 11 2017

Cc: sjg@chromium.org
Owner: ----

Comment 4 by sjg@chromium.org, Dec 11 2017

Components: Factory
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 12 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by sjg@chromium.org, Dec 13 2017

Owner: sjg@chromium.org

Comment 7 by sjg@chromium.org, Dec 18 2017

Cc: marcochen@chromium.org
CL ready for Marco to approve

https://chromium-review.googlesource.com/c/chromiumos/platform/firmware/+/832950
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 20 2017

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/23b403ad0c187fe10ab1afff61f699a07fd1b9e6

commit 23b403ad0c187fe10ab1afff61f699a07fd1b9e6
Author: Simon Glass <sjg@chromium.org>
Date: Wed Dec 20 03:29:05 2017

pack_firmware: Use 'mosys platform signature' to get sig ID

We now support reading the signature ID in mosys. Update the firmware
updater to use this path for unified builds. This means that vpd is not
directly used anymore, but we keep it around to match normal usage of the
updater.

BUG= chromium:775543 , chromium:793923 
TEST=python pack_firmware_functest.py &&  python pack_firmware_unittest.py
Reviewed-on: https://chromium-review.googlesource.com/791534

Change-Id: I3fbc6055c3164390a741b2eddcabc7516cb29048
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/832950
Reviewed-by: Marco Chen <marcochen@chromium.org>
Commit-Queue: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>

[modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_dist/updater4.sh
[modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/functest/mosys
[modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_firmware_functest.py
[modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/functest/vpd
[modify] https://crrev.com/23b403ad0c187fe10ab1afff61f699a07fd1b9e6/pack_dist/common.sh

Comment 9 by sjg@chromium.org, Jan 2 2018

Status: Fixed (was: Available)
Labels: -Merge-Approved-64

Sign in to add a comment