New issue
Advanced search Search tips

Issue 793916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 728695



Sign in to add a comment

When switches::IsMusHostingViz() == false, the touch events don't work correctly in ARC apps.

Project Member Reported by penghuang@chromium.org, Dec 11 2017

Issue description

On Kevin, touch events inside of top left 1/4 screen can work in ARC apps. Touch events in other part screen will not work. But all mouse events are fine.


 
Blocking: 728695

Comment 2 by sky@chromium.org, Jan 8 2018

I wonder if this is related to 794262. I haven't been able to run on device and investigate 794262 because of 795069.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ecae82c9410f79e36009422a4c63c31118f978a

commit 7ecae82c9410f79e36009422a4c63c31118f978a
Author: Peng Huang <penghuang@chromium.org>
Date: Thu Jan 11 23:26:23 2018

exo: Fix the touch problem for ARC apps

WindowTargeter::FindTargetInRootWindow() uses the wrong touch event
location to check with the bounds of root window. It causes some touch
events are dispatched to the root window instead of the right target.
This change uses the root_location of touch events to fix the problem.

Bug:  793916 
Test: ARC apps with mushroom and cash
Change-Id: I4468d6e3a4608ac69fafa9236abe16a4905e3260
Reviewed-on: https://chromium-review.googlesource.com/857693
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528810}
[modify] https://crrev.com/7ecae82c9410f79e36009422a4c63c31118f978a/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/7ecae82c9410f79e36009422a4c63c31118f978a/ui/aura/window_targeter.cc
[modify] https://crrev.com/7ecae82c9410f79e36009422a4c63c31118f978a/ui/events/event.h

Status: Fixed (was: Assigned)
Components: -Internals>MUS Internals>Services>WindowService
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b33aeead03e03830689494b2f2aec6a4acc600

commit 85b33aeead03e03830689494b2f2aec6a4acc600
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Aug 16 01:40:48 2018

ws: Fix WindowTargeter touch event location check

Use event.location() + ScreenPosition client in FindTargetInRootWindow:
 - location() is in |root_window| coordinates for the ws and clients
 - root_location() is *not* in |root_window| coordinates for clients:
   - |root_window| is the client-root (the top-level client app window)
   - root_location() is Ash's display-root coords (full display bounds)

Add a WindowTreeTest for event locations and root locations.
Add a WindowTargeterTest for FindTargetInRootWindow and regressions.

Bug:  873763 ,  793916 
Test: KSV (Ctrl-Alt-/), Arc, Mash, 2nd display, etc. touch input works.
Change-Id: I7ae541203181f9fc5c65449a10ca927f90d29d96
Reviewed-on: https://chromium-review.googlesource.com/1176462
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583488}
[modify] https://crrev.com/85b33aeead03e03830689494b2f2aec6a4acc600/services/ui/ws2/window_tree_unittest.cc
[modify] https://crrev.com/85b33aeead03e03830689494b2f2aec6a4acc600/ui/aura/window_targeter.cc
[modify] https://crrev.com/85b33aeead03e03830689494b2f2aec6a4acc600/ui/aura/window_targeter_unittest.cc

Sign in to add a comment