New issue
Advanced search Search tips

Issue 793899 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
jam@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

browser_tests makes real HTTP requests with NetworkService enabled

Project Member Reported by reillyg@chromium.org, Dec 11 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Run browser_tests --gtest_filter =ExtensionApiTest.DoNotOpenUninstallUrlForBlacklistedExtensions --enable-features=NetworkService

What is the expected result?
Test passes.

What happens instead?
Test fails because the real google.com redirects http://www.google.com to https://www.google.com/gws_rd=ssl.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df350de85798326acf0f5370f796f02049c16bd6

commit df350de85798326acf0f5370f796f02049c16bd6
Author: Reilly Grant <reillyg@chromium.org>
Date: Mon Dec 11 20:05:29 2017

Disable browser test failing with NetworkService

This new test* fails with the NetworkService enabled because it reaches
out to google.com and is surprised that there is a redirect served by
the real thing. Tests should not be making actual network requests.

* ExtensionApiTest.DoNotOpenUninstallUrlForBlacklistedExtension

Bug:  793899 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic866fd1f8ac48428a8179f5cecbd60d5ff17b5be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Tbr: jam@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/820152
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523181}
[modify] https://crrev.com/df350de85798326acf0f5370f796f02049c16bd6/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 2 by reillyg@chromium.org, Dec 11 2017 

NetworkServiceTestImpl [1] seems to be using the same content::TestHostResolver that non-NetworkService browser tests use so I cannot explain why real network requests are happening. 

[1] https://cs.chromium.org/chromium/src/content/public/test/network_service_test_helper.cc?sq=package:chromium&l=63

Comment 3 by reillyg@chromium.org, Dec 11 2017

Components: -Test Internals>Services>Network
Labels: -NetworkService

Comment 4 by jam@chromium.org, Jan 12 2018

Status: Fixed (was: Untriaged)
Fixed in r528763
►

Sign in to add a comment