New issue
Advanced search Search tips

Issue 793887 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
rdevlin....@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ExtensionStorageMonitor observes profile destruction

Project Member Reported by est...@chromium.org, Dec 11 2017 
it does cleanup with the profile is destroyed, but it seems this shouldn't be necessary since it's a profile-keyed service. Maybe it's like that due to historical reasons? Or for shutdown ordering reasons (should instead use DependsOn)?

See discussion here[1] (this should have been an inline TODO but I forgot to press "save" before uploading and submitting).

[1] https://chromium-review.googlesource.com/c/chromium/src/+/817657
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa

commit 0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa
Author: Evan Stade <estade@chromium.org>
Date: Tue Apr 10 23:09:18 2018

Remove profile destruction notification observation from
ExtensionStorageMonitor.

Bug: 793887
Change-Id: I877a8734b419054da94b307bab5389bada8aab62
Reviewed-on: https://chromium-review.googlesource.com/1000114
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549670}
[modify] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/chrome/browser/extensions/extension_storage_monitor.h
[modify] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
►

Sign in to add a comment