New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793883 link

Starred by 1 user
Status: Duplicate
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Create "Data Saver Server Previews" flag

Project Member Reported by thanhdle@chromium.org, Dec 11 2017 
Options: Default, Enabled, Enabled (Prefer Lite Page), Disabled

This will explain that the server makes part of the decision and that this is dependent on NQE and client user blacklist. It will also reference the back end configuration to get LoFi vs LitePage. The Default is enabled on android, disabled on other platforms.

Doc: https://docs.google.com/document/d/1cyJ-TxBBDdX6GyQzTMNUUzs3Rdis28HhIGsA--YsNxQ

Comment 1 by thanhdle@chromium.org, Dec 11 2017

Description: Show this description

Comment 2 by thanhdle@chromium.org, Dec 13 2017

Mergedinto: 753594
Status: Duplicate (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/659cb100f81180d2b9147628ddfd564861b18f17

commit 659cb100f81180d2b9147628ddfd564861b18f17
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Dec 20 22:00:19 2017

Added "Data Saver Server Previews" flag.

Removed "Data Saver Lo-Fi mode" and "Lite pages for Data Saver Lo-Fi mode" and
replaced them with the new flag.

Doc: https://docs.google.com/document/d/1cyJ-TxBBDdX6GyQzTMNUUzs3Rdis28HhIGsA--YsNxQ

Bug:  793883 
Change-Id: Id64a3aebf76606cb736fca6a6f9962fe15ca3b3c
Reviewed-on: https://chromium-review.googlesource.com/823079
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525483}
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/chrome/browser/about_flags.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/tools/chrome_proxy/webdriver/lite_page.py
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/tools/chrome_proxy/webdriver/lofi.py
[modify] https://crrev.com/659cb100f81180d2b9147628ddfd564861b18f17/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f090efa5314516a6ec4eecaa4be155f91d6b192

commit 5f090efa5314516a6ec4eecaa4be155f91d6b192
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Jan 03 06:53:19 2018

Added "Ignore Previews Blacklist" flag to chrome://flags.

Added the link to the flag on chrome://interventions-internals.

The value is overridden by the the "Ignore Blacklist" button on
chrome://interventions-internals. When all observer removed, the
ignore status is reset to the flag value.

Doc:
https://docs.google.com/document/d/1cyJ-TxBBDdX6GyQzTMNUUzs3Rdis28HhIGsA--YsNxQ

Screenshot:
https://drive.google.com/a/chromium.org/file/d/1UjyYyJV3JTBg_qJTKT98u-8eruuBmdZR

Bug:  793883 
Change-Id: I224b6f9b7a3f52d36481e15afeee994f0b68df02
Reviewed-on: https://chromium-review.googlesource.com/841428
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526641}
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/chrome/browser/about_flags.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/core/BUILD.gn
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/core/previews_logger.cc
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/core/previews_logger_unittest.cc
[add] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/core/previews_switches.cc
[add] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/components/previews/core/previews_switches.h
[modify] https://crrev.com/5f090efa5314516a6ec4eecaa4be155f91d6b192/tools/metrics/histograms/enums.xml
►

Sign in to add a comment