Reduce hang detection interval to 15 sec for non-stable chromeos channels |
|||
Issue descriptionkanliu@ and zelidrag@ saw hangs recently that seemed to take a long time before the liveness checker engaged (see bug 793439 ). Looking at session_manager_main.cc I see the default is for a 60s hang detection. That seems way too long. We should consider shortening it, at least for dev and beta users. I propose that we go to the 5s interval on dev and beta. We might want to consider a reduction in general - if we're unable to process events for 5s, something is seriously wrong and getting a crash report would be helpful. derat@ has documented the hang detection code at https://chromium.googlesource.com/chromiumos/platform2/+/master/login_manager/docs/chrome_hang_detection.md
,
Dec 12 2017
https://chromium-review.googlesource.com/821730
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/631313f42ae26091eff1f72a3869407a359dbc19 commit 631313f42ae26091eff1f72a3869407a359dbc19 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Dec 13 20:33:39 2017 login: Lower hang detection interval on non-stable channels. Hang detection interval is now 15 sec for non-stable channels. Fix desktopui_HangDetector: The flag file /run/session_manager/enable_hang_detection was used to reduce the hangout detection interval from 60 -> 5 sec for the autotest desktopui_HangDetector. This autotest is currently failing because it expects chrome to restart, but since the test runs on a test image, session_manager merely prints an error message. We now also use the flag file to indicate that we want session manager to send SIGABORT to chrome. Some style cleanup. BUG= chromium:793880 TEST=desktopui_HangDetector Change-Id: I42f20ac534e4af8134bdb2be12c28e6f2e32148f Reviewed-on: https://chromium-review.googlesource.com/821730 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/631313f42ae26091eff1f72a3869407a359dbc19/login_manager/session_manager_main.cc
,
Dec 13 2017
Reduced to 15 sec based on review feedback. |
|||
►
Sign in to add a comment |
|||
Comment 1 by derat@chromium.org
, Dec 11 2017